Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable no-curly-component-invocation and no-implicit-this rules for gjs / gts files #2844

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Disable no-curly-component-invocation and no-implicit-this rules for gjs / gts files #2844

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4a31d5
Start adding gjs/gts overrides to the recommended config, per: https:…
NullVoxPopuli Mar 14, 2023
49700e4
Merge branch 'master' into patch-2
bmish Mar 15, 2023
889e7f4
Update recommended.js
NullVoxPopuli Mar 15, 2023
7672557
Remove trailing invisible characters
NullVoxPopuli Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/config/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,13 @@ export default {
'style-concatenation': 'error',
'table-groups': 'error',
},
overrides: [
{
files: ['**/*.gjs', '**/*.gts'],
rules: {
'no-curly-component-invocation': 'off',
'no-implicit-this': 'off',
Comment on lines +110 to +111
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment next to each of these rules explaining why they are disabled for gjs/gts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

Copy link
Member

@bmish bmish Mar 15, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Lint failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I get for trying to do this all in-browser 🙃

},
},
],
};