Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override for gjs files in recommended config #2891

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented May 23, 2023

Resolves #2785
The perceived effect of this bug is that gjs and gts files do not have these rules disabled: https://github.com/ember-template-lint/ember-template-lint/blob/master/lib/config/recommended.js#L94

The recommended config has overrides, but that overrides was not making it in to user-configs.

Using the default config,

'use strict';

module.exports = {
  plugins: [],
  extends: 'recommended'
};

Before

❯ pnpm ember-template-lint --print-config app/components/limber/layout/controls/index.gts
...
  "overrides": [],

After

❯ pnpm ember-template-lint --print-config app/components/limber/layout/controls/index.gts
...
  "overrides": [
    {
      "files": [
        "**/*.gjs",
        "**/*.gts"
      ],
      "rules": {
        "no-curly-component-invocation": {
          "config": false,
          "severity": 0
        },
        "no-implicit-this": {
          "config": false,
          "severity": 0
        }
      }
    }
  ],

@bmish bmish added the bug label May 23, 2023
@bmish bmish changed the title Fix extends.overrides Fix override for gjs files in recommended config May 23, 2023
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks.

@bmish bmish merged commit a8344ed into ember-template-lint:master May 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-implicit-this + strict mode false positives
2 participants