Fix crash in no-unsupported-role-attributes rule
#2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case where aria-query's role mapping data does not have an attributes property defined. Resolves ember-template-lint#2916
bmish
approved these changes
Jun 17, 2023
There was a problem hiding this comment.
Fixing the crash for now sounds good. Thanks!
CC: @judithhinlung the rule author who perhaps can speak to the desired behavior here.
bmish
changed the title
no-unsupported-role-attributes rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2916.
Handle the case where aria-query's role mapping data does not have an attributes property defined.
Note: as I mentioned in #2916 I'm a little confused by the current behavior where an
<input>with atypethat doesn't match anything sort of defaults to being treated like a<button>. If that's correct (or correct enough) then this should work, but if that's also a bug then we'll want a different solution here.