Add support for Ember v5 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Apr 1, 2023
|
FWIW, I believe this is holding up the |
bertdeblock
approved these changes
Apr 3, 2023
|
Now that ember v5 is in beta, any chance to get a new release here with this major addition? Consuming addons are certainly going to come across the limitation with ember-try scenarios, and I'd imagine some apps will want to start testing against ember v5... 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
@ember/render-modifierspresently does not have anything deprecated1 for removal in ember-source v5, I figure it'd be good to add v5 to the peer list.Footnotes
There is private api usage though, but I don't see that getting removed in v5 either ↩