Ship own types (copy from DT) #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
May 15, 2023
| @@ -84,7 +86,7 @@ | |||
| "release-it": "^14.11.6", | |||
| "release-it-lerna-changelog": "^3.1.0", | |||
| "rimraf": "^3.0.2", | |||
| "typescript": "^4.4.4", | |||
| "typescript": "^5.0.4", | |||
There was a problem hiding this comment.
looks like this didn't change -- I didn't even check if this project already had TS available 😅
chriskrycho
requested changes
May 15, 2023
…efault of 12 -- TS 5.1 does not support node 12
chriskrycho
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the types and type-tests from DT, here: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/ember__string
This PR enables folks using
ember-source@v5to use the built-in types and not have to install@types/ember__stringprior to ember-source@v5, the types for ember-string were here: https://github.com/emberjs/ember.js/blob/v4.12.0/types/preview/%40ember/string/index.d.ts
but
ember-source@v5removed@ember/string, per deprecation plan.