-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship own types (copy from DT) #380
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4805654
Copy over Types and type-tests from DT: https://github.com/Definitely…
NullVoxPopuli 17eeb95
Add CI
NullVoxPopuli 09548f2
Use expect-type
NullVoxPopuli 12efafb
Change tsVersion matrix to be 4.9+
NullVoxPopuli 6d1b289
Fix typo in types-scenarios task
NullVoxPopuli 63c3fb5
lint:fix
NullVoxPopuli 08eab70
Stumble through using yarn to swap out the TS Version
NullVoxPopuli 49f5a3e
5.1 is still pre-release, so switch the types matrix to use the 'beta…
NullVoxPopuli d1f54f3
Maybe yarn needs to invoke tsc
NullVoxPopuli 0125775
Run the types-scenarios checking with node 14, instead of the volta-d…
NullVoxPopuli File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export function camelize(str: string): string; | ||
| export function capitalize(str: string): string; | ||
| export function classify(str: string): string; | ||
| export function dasherize(str: string): string; | ||
| export function decamelize(str: string): string; | ||
| export function underscore(str: string): string; | ||
| export function w(str: string): string[]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { | ||
| dasherize, | ||
| camelize, | ||
| capitalize, | ||
| classify, | ||
| decamelize, | ||
| underscore, | ||
| w, | ||
| } from '@ember/string'; | ||
|
|
||
| import { expectTypeOf } from 'expect-type'; | ||
|
|
||
| // @ts-expect-error | ||
| dasherize(); | ||
| // @ts-expect-error | ||
| dasherize('', ''); | ||
|
|
||
| expectTypeOf(dasherize('blue man group')).toBeString(); | ||
|
|
||
| // @ts-expect-error | ||
| camelize(); | ||
| // @ts-expect-error | ||
| camelize('', ''); | ||
|
|
||
| expectTypeOf(camelize('blue man group')).toBeString(); | ||
|
|
||
| // @ts-expect-error | ||
| decamelize(); | ||
| // @ts-expect-error | ||
| decamelize('', ''); | ||
|
|
||
| expectTypeOf(decamelize('blue man group')).toBeString(); | ||
|
|
||
| // @ts-expect-error | ||
| underscore(); | ||
| // @ts-expect-error | ||
| underscore('', ''); | ||
|
|
||
| expectTypeOf(underscore('blue man group')).toBeString(); | ||
|
|
||
| // @ts-expect-error | ||
| w(); | ||
| // @ts-expect-error | ||
| w('', ''); | ||
|
|
||
| expectTypeOf(w('blue man group')).toMatchTypeOf<string[]>(); | ||
|
|
||
| // @ts-expect-error | ||
| classify(); | ||
| // @ts-expect-error | ||
| classify('', ''); | ||
|
|
||
| expectTypeOf(classify('blue man group')).toBeString(); | ||
|
|
||
| // @ts-expect-error | ||
| capitalize(); | ||
| // @ts-expect-error | ||
| capitalize('', ''); | ||
|
|
||
| expectTypeOf(capitalize('blue man group')).toBeString(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "@tsconfig/ember", | ||
| "compilerOptions": { | ||
| "paths": { | ||
| "@ember/string": ["../"] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this didn't change -- I didn't even check if this project already had TS available 😅