Implement testing RFC #1211
Merged
Implement testing RFC #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Apr 12, 2022
| let renderSettled: () => Promise<void>; | ||
|
|
||
| // TODO need to add the actual version `@ember/renderer` landed once we know it | ||
| if (macroCondition(dependencySatisfies('ember-source', '>=4.9999999.0'))) { |
There was a problem hiding this comment.
Ok, now that the Ember change has landed for realz let's update this to 4.5.0-beta.1.
Co-authored-by: Robert Jackson <me@rwjblue.com>
Co-authored-by: Robert Jackson <me@rwjblue.com>
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
9ccfdf6
to
8d935fb
Compare
rwjblue
reviewed
Apr 12, 2022
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
11eeb34
to
a749f81
Compare
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
d41647a
to
2c6b47f
Compare
rwjblue
requested changes
Apr 12, 2022
addon-test-support/@ember/test-helpers/-internal/is-component.ts
Outdated
Show resolved
Hide resolved
rwjblue
approved these changes
Apr 21, 2022
|
|
||
| const OUTLET_TEMPLATE = hbs`{{outlet}}`; | ||
| const EMPTY_TEMPLATE = hbs``; | ||
| const INVOKE_PROVIDED_COMPONENT = hbs`<this.ProvidedComponent />`; |
There was a problem hiding this comment.
@chriskrycho here is this mystic this.ProvidedComponent that fails ember-optimized scenario
SergeAstapov
added a commit
to adopted-ember-addons/ember-keyboard
that referenced
this pull request
Jul 8, 2022
PR emberjs/ember-test-helpers#1211 (released in v2.8.0) made `ember-source` a peerDependency of `@ember/test-helpers`. In case of `ember-keyboard` monorepo setup, package `ember-source` does not get hoisted and stay in the `test-app/node_modules` but at the same time `@ember/test-helpers` gets hoisted as well as some another version of `ember-source`. By not hoisting `@ember/test-helpers` in the `test-app` package we avoid this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the majority of emberjs/rfcs#785. More specifically, it adds:
rerenderhelper that allows tests to wait exclusively on render operations (as opposed to full settledness).renderthat accepts components as well as templatesNotably, this PR does not address the component named argument ergonomics issue mentioned in the RFC. That will need to come in a follow-on RFC/PR.
TODO
renderSettledvia renderer package ember.js#20053 for therenderSettledAPIrenderSettledis actually landed and shipped, we'll need to update therenderSettledponyfill that lives inember-test-helpersto actually use the correct Ember version.