[FEATURE default helper manager] Add the default helper manager #20052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Windvis
force-pushed
the
feature/default-helper-manager
branch
from
ac530c2
to
aa53c47
Compare
Windvis
force-pushed
the
feature/default-helper-manager
branch
from
aa53c47
to
b081915
Compare
This updates the Glimmer VM to version 0.84.2 which includes the default helper manager and a feature flag to conditionally enable that feature in Ember.
Windvis
force-pushed
the
feature/default-helper-manager
branch
from
b081915
to
b9436fd
Compare
chancancode
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
@Windvis do you have anything else you think needs to be done or are you happy with everything? at a glance it seems good to me
|
@chancancode any reason not to merge this? |
|
@chancancode I think it's good to go. 👍 The RFC mentions some documentation updates but that's part of the guides so nothing needs to be added here I think. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Glimmer VM to version 0.84.2 which includes the default helper manager and a feature flag to conditionally enable that feature in Ember.
This PR supersedes #19973.