Fix a problem where plain functions can't be used as helper if they are not passed through the strict mode context object #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the performance check faillure is about. 🤔 |
chancancode
reviewed
Apr 12, 2022
|
Thanks for catching this! |
Windvis
force-pushed
the
fix/default-helper-manager-functions-as-props-and-args
branch
from
ce29ff1
to
aca1a5c
Compare
Windvis
commented
Apr 13, 2022
|
The perf test also passed so I think it was just a random failure last time. I'll check back tomorrow to give you some time to make the change you wanted. If not I will probably merge it anyway since it can always be refactored later. |
…re not passed through the strict mode context object It seems functions passed as strict mode context values follow a different code path than component arguments and class properties so the error wasn't shown there.
Windvis
force-pushed
the
fix/default-helper-manager-functions-as-props-and-args
branch
from
aca1a5c
to
ebdc58d
Compare
Windvis
commented
Apr 13, 2022
Windvis
deleted the
fix/default-helper-manager-functions-as-props-and-args
branch
|
@chancancode Thank you for the quick reviewing! |
|
@Windvis published v0.84.2 with this |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on emberjs/ember.js#20052 I noticed that an error was thrown when using a function that was stored on a component class property. The
hasInternalHelperManagerutil is used there but it doesn't pass through the default helper manager fallback behavior code so it returns false and the error is shown.It seems functions passed as strict mode context values follow a different code path than component arguments and class properties so the error wasn't shown in the tests of the original PR.