[BUGFIX LTS] Fix cyclic module crash #20461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
approved these changes
May 17, 2023
chriskrycho
approved these changes
May 17, 2023
`@ember/engine/index` and `@ember/engine/instance` have circular dependencies on each other. This would be OK, except that `instance.ts` is eagerly copying a class off `index.ts`, at a point in time where it might not actually be available. Whether this bug hits you depends on which side of the pair gets evaluated first. I only happened hit it when testing an app with engines and fastboot on Ember 5. This fix is to not eagerly pull the class off the module.
|
Rewrote the commit and the PR to say "BUGFIX LTS". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ember/engine/indexand@ember/engine/instancehave circular dependencies on each other.This would be OK, except that
instance.tsis eagerly copying a class offindex.ts, at a point in time where it might not actually be available.Whether this bug hits you depends on which side of the pair gets evaluated first. I only happened to hit it when testing an app with engines and fastboot on Ember 5. The exception looks like:
The fix is to not eagerly pull the class off the module.