Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX LTS] Fix cyclic module crash #20461

Merged
merged 1 commit into from
May 17, 2023
Merged

[BUGFIX LTS] Fix cyclic module crash #20461

merged 1 commit into from
May 17, 2023

Commits on May 17, 2023

  1. [BUGFIX LTS] Fix cyclic module crash 

    `@ember/engine/index` and `@ember/engine/instance` have circular dependencies on each other.

This would be OK, except that `instance.ts` is eagerly copying a class off `index.ts`, at a point in time where it might not actually be available.

Whether this bug hits you depends on which side of the pair gets evaluated first. I only happened hit it when testing an app with engines and fastboot on Ember 5.

This fix is to not eagerly pull the class off the module.
    @ef4
    ef4 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    7c31ada View commit details
    Browse the repository at this point in the history