Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlb: add how to use #33818

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

dlb: add how to use #33818

wants to merge 8 commits into from

Conversation

daixiang0
Copy link
Member

Add doc about how to use.

Commit Message:
Additional Description:
Risk Level: low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax self-assigned this Apr 26, 2024
@phlax
Copy link
Member

phlax commented Apr 26, 2024

/docs

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/33818/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #33818 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member

phlax commented Apr 30, 2024

/retest

@adisuissa
Copy link
Contributor

/wait on CI

@repokitteh-read-only repokitteh-read-only bot added waiting deps Approval required for changes to Envoy's external dependencies and removed waiting labels Apr 30, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #33818 was synchronize by daixiang0.

see: more, trace.

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that some of the modifications are not related to the PR.
/wait on cleanup

Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
Copy link
Member Author

@adisuissa sorry for mistake :(

Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Loong <loong.dai@intel.com>
@phlax
Copy link
Member

phlax commented May 10, 2024

still failing format and publishing ci

/wait

Signed-off-by: Loong <loong.dai@intel.com>
This reverts commit 888a152.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants