Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iouring: fix the IoUringImpl tests for latest kernel #33833

Merged
merged 6 commits into from Apr 30, 2024

Conversation

soulxu
Copy link
Member

@soulxu soulxu commented Apr 28, 2024

Commit Message: iouring: fix the IoUringImpl tests for the arm CI
Additional Description:
The existing tests assume that the I/O request can be finished right after the request submission. Add waiting function before checking the I/O request completion, making those tests more reliable.

Risk Level: low
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #33829

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33833 was opened by soulxu.

see: more, trace.

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
@soulxu soulxu changed the title iouring: debug arm CI iouring: fix the IoUringImpl tests for the arm CI Apr 29, 2024
@soulxu soulxu marked this pull request as ready for review April 29, 2024 13:43
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
@soulxu
Copy link
Member Author

soulxu commented Apr 29, 2024

cc @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @soulxu altho thinking the pr title should be more "fix the IoUringImpl tests for latest kernel"

probably good to get a c++ review also

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa
Copy link
Contributor

Assigning Alyssa as a senior-maintainer with much tests timeout experience
/assign @alyssawilk

@soulxu soulxu changed the title iouring: fix the IoUringImpl tests for the arm CI iouring: fix the IoUringImpl tests for latest kernel Apr 29, 2024
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im going to land this as it reverts the hacky workaround i added which i think may be breaking mac builders

lgtm, thanks @soulxu

@phlax phlax merged commit 48e5936 into envoyproxy:main Apr 30, 2024
51 checks passed
phlax pushed a commit to phlax/envoy that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>

Signed-off-by: Alex Xu <hejie.xu@intel.com>
phlax pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: He Jie Xu <hejie.xu@intel.com>

Signed-off-by: Alex Xu <hejie.xu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io_uring test fails with newer kernel (arm?)
4 participants