New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iouring: fix the IoUringImpl tests for latest kernel #33833
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
cc @phlax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @soulxu altho thinking the pr title should be more "fix the IoUringImpl tests for latest kernel"
probably good to get a c++ review also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Assigning Alyssa as a senior-maintainer with much tests timeout experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im going to land this as it reverts the hacky workaround i added which i think may be breaking mac builders
lgtm, thanks @soulxu
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Alex Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Alex Xu <hejie.xu@intel.com>
Commit Message: iouring: fix the IoUringImpl tests for the arm CI
Additional Description:
The existing tests assume that the I/O request can be finished right after the request submission. Add waiting function before checking the I/O request completion, making those tests more reliable.
Risk Level: low
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #33829