Fix "Windows workflow broken since recent commit" #246
Conversation
As per the README, and now tested, they should be found in INSTALL_DIR_FOR_... followed by their name
We're missing the /bin
These were previously used and pushed as generated but since npm run build-dist doesn't rebuild the whole dist folder, these just "stayed there"
There was a problem hiding this comment.
Instead of "not failing it they're not there" (this was a best effort, after all), we now fail if the variables are incorrectly populated. This is Ubuntu!
There was a problem hiding this comment.
Instead of "not failing it they're not there" (this was a best effort, after all), we now fail if the variables are incorrectly populated. This is Windows.
There was a problem hiding this comment.
All the removed dist files are no longer required. They're remains from when the action did stuff using shell scripts, which it no longer does. The npm stuff's now been fixed so dist is always recreated.
There was a problem hiding this comment.
Changes here:
- fix broken variable path to include
bin - fix Windows/rebar3 location to have code similar to Ubuntu, on Windows (also inside
bin
There was a problem hiding this comment.
All the removed dist files are no longer required. They're remains from when the action did stuff using shell scripts, which it no longer does. The npm stuff's now been fixed so dist is always recreated.
There was a problem hiding this comment.
All the removed dist files are no longer required. They're remains from when the action did stuff using shell scripts, which it no longer does. The npm stuff's now been fixed so dist is always recreated.
There was a problem hiding this comment.
All the removed dist files are no longer required. They're remains from when the action did stuff using shell scripts, which it no longer does. The npm stuff's now been fixed so dist is always recreated.
There was a problem hiding this comment.
All the removed dist files are no longer required. They're remains from when the action did stuff using shell scripts, which it no longer does. The npm stuff's now been fixed so dist is always recreated.
There was a problem hiding this comment.
Check comments in the dist/.js file.
Description
Closes #245. Check that for more information.
CI now proves the implementation of the environment variables is Ok, as was expected.