Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Windows workflow broken since recent commit" #246

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Fix "Windows workflow broken since recent commit" #246

merged 3 commits into from
Jan 28, 2024

Commits on Jan 28, 2024

  1. Test if the binaries are found where we expect them 

    As per the README, and now tested, they should be found in
INSTALL_DIR_FOR_... followed by their name
    @paulo-ferraz-oliveira
    paulo-ferraz-oliveira committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a145f88 View commit details
    Browse the repository at this point in the history

  2. Fix exposed INSTALL_DIR_FOR_${toolName} variables 

    We're missing the /bin
    @paulo-ferraz-oliveira
    paulo-ferraz-oliveira committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    83b8ed0 View commit details
    Browse the repository at this point in the history

  3. Remove dist files no longer required by action 

    These were previously used and pushed as generated
but since npm run build-dist doesn't rebuild the
whole dist folder, these just "stayed there"
    @paulo-ferraz-oliveira
    paulo-ferraz-oliveira committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    fa76b29 View commit details
    Browse the repository at this point in the history