Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Fix: don't render links when plugin replaces core rule #727

Merged
merged 1 commit into from May 9, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 16 additions & 11 deletions docs/rules/index.liquid
Expand Up @@ -50,17 +50,22 @@ layout: doc
<td markdown="1">
<a href="{{ rule.name }}">{{ rule.name }}</a>
</td>
{% if rule.replacedBy.size > 0 %}
<td class="replaced-by" markdown="1">
{% for replaced in rule.replacedBy %}
<a href="{{ replaced }}">{{ replaced }}</a>
{% endfor %}
</td>
{% else %}
<td class="replaced-by" markdown="1">
<p class="text-muted">(no replacement)</p>
</td>
{% endif %}
<td class="replaced-by" markdown="1">
{% assign hasReplacement = false %}
{% if rule.replacedBy.size > 0 %}
{% for replaced in rule.replacedBy %}
{% comment %} Do not link to rule docs in 3rd party plugins. {% endcomment %}
{% assign ruleNameSegments = replaced | split: "/" %}
{% if ruleNameSegments.size == 1 %}
<a href="{{ replaced }}">{{ replaced }}</a>
{% assign hasReplacement = true %}
{% endif %}
{% endfor %}
{% endif %}
{% if hasReplacement == false %}
<p class="text-muted">(no replacement)</p>
{% endif %}
</td>
</tr>
{% endfor %}
</tbody>
Expand Down