New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mastodon link #381

Merged

nzakas merged 6 commits into eslint:main from amareshsm:add-mastodon-link

Dec 13, 2022

Member

amareshsm commented Dec 10, 2022 •

edited

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Added Mastodon link along with our other social buttons.

Related Issues

Resolves #378

amareshsm added 3 commits

December 10, 2022 15:04


          feat: add mastodon link

c72ebf5


          Update social-icons.html

22d0e65


          lint file

d612b8a

netlify bot commented Dec 10, 2022 •

edited

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`79e948e`

eslint-github-bot bot added feature triage labels

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/639610b68f8ab90008f695f3
😎 Deploy Preview	https://deploy-preview-381--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/639610b6b665b20009b4acca
😎 Deploy Preview	https://deploy-preview-381--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/639610b6b629840009766003
😎 Deploy Preview	https://deploy-preview-381--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions bot added the translation label


          fix indendation

d1fa766

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/639610b658d93800081ef0d1
😎 Deploy Preview	https://deploy-preview-381--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/639610b6af8f8d0008d9109a
😎 Deploy Preview	https://deploy-preview-381--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`d612b8a`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/639461eccde5220008b1097e
😎 Deploy Preview	https://deploy-preview-381--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/639610b629f2490008e8a3ac
😎 Deploy Preview	https://deploy-preview-381--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Dec 10, 2022 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`79e948e`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/639610b6a4072600084547b3
😎 Deploy Preview	https://deploy-preview-381--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

amareshsm added accepted and removed triage translation labels

harish-sethuraman approved these changes

View reviewed changes

harish-sethuraman requested a review from kecrily

December 10, 2022 11:37


          add rel attribute

f637fca

github-actions bot added the translation label

kecrily reviewed

View reviewed changes

src/_includes/components/social-icons.html Outdated Show resolved Hide resolved


          Update src/_includes/components/social-icons.html

79e948e

Co-authored-by: Percy Ma <kecrily@gmail.com>

kecrily approved these changes

View reviewed changes

Member

kecrily left a comment

LGTM

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM. Thanks!

Member

nzakas commented Dec 13, 2022

Hey everyone - if you approve a PR and don't merge it, please be sure to explain why not. You could say "LGTM but would like someone else to double-check." That way, we know why the PR wasn't merged.

nzakas merged commit f2fcf5a into eslint:main

Member

harish-sethuraman commented Dec 13, 2022 •

edited

Will add explanation going forward ✅. We found a minor layout problem being caused due to adding newer link. This can be seen in playground as well. That was why I was waiting 😅 . Should we fix it going forward or revert the PR?
eslint/eslint#16638 (comment) @nzakas

Member

nzakas commented Dec 14, 2022

And that's why it's important to explain why you didn't merge. :)

Let's fix it forward. We should just wrap the icons in this layout.

Member Author

amareshsm commented Dec 14, 2022

And that's why it's important to explain why you didn't merge. :)

Let's fix it forward. We should just wrap the icons in this layout.

sure we can wrap the icons. I will send a pr.

amareshsm mentioned this pull request

fix: social icons layout bug #382

Closed

1 task

shanpriyan mentioned this pull request

fix: footer social icons layout with nowrap #386

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment