Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: space-infix-ops reports violating operator #10934

Merged

Conversation

madbence
Copy link
Contributor

@madbence madbence commented Oct 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

space-infix-ops

Does this change cause the rule to produce more or fewer warnings?

no change

How will the change be implemented? (New option, new default behavior, etc.)?

change the error message to include the violating operator

Please provide some example code that this change will affect:

var foo=1;

What does the rule currently do for this code?

reports Infix operators must be spaced..

What will the rule do after it's changed?

reports Operator '=' must be spaced..

What changes did you make? (Give an overview)

Clarify which operator violated the rule (on a longer line with many operators this can be confusing)

Is there anything you'd like reviewers to focus on?

? or : are not really an operators on their own, but i guess that's not a big deal.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 7, 2018
@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 7, 2018
@platinumazure platinumazure self-assigned this Oct 7, 2018
@platinumazure
Copy link
Member

I like the idea. I will champion this proposal with the team. Thanks for contributing!

@madbence
Copy link
Contributor Author

@platinumazure any progress with this?

@platinumazure
Copy link
Member

@madbence Thanks for following up, I lost track of this.

I'm trying to find one more 👍 from the team. I'll see if I can get that done today.

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 21, 2018
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now it's accepted, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Waiting another day or two in case others want to review before merging.

@platinumazure
Copy link
Member

Hi @madbence, apologies for letting this slip through the cracks.

I've restarted the Travis build to make sure this still passes on the latest master. I assume it will; if it does, I'll merge this tonight. Thanks!

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 9666aba into eslint:master Dec 8, 2018
@madbence madbence deleted the space-infix-ops-multiple-reports branch December 10, 2018 00:14
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 7, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants