New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: space-infix-ops reports violating operator #10934
Update: space-infix-ops reports violating operator #10934
Conversation
I like the idea. I will champion this proposal with the team. Thanks for contributing! |
@platinumazure any progress with this? |
@madbence Thanks for following up, I lost track of this. I'm trying to find one more 👍 from the team. I'll see if I can get that done today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, now it's accepted, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Waiting another day or two in case others want to review before merging.
Hi @madbence, apologies for letting this slip through the cracks. I've restarted the Travis build to make sure this still passes on the latest master. I assume it will; if it does, I'll merge this tonight. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
space-infix-ops
Does this change cause the rule to produce more or fewer warnings?
no change
How will the change be implemented? (New option, new default behavior, etc.)?
change the error message to include the violating operator
Please provide some example code that this change will affect:
What does the rule currently do for this code?
reports
Infix operators must be spaced.
.What will the rule do after it's changed?
reports
Operator '=' must be spaced.
.What changes did you make? (Give an overview)
Clarify which operator violated the rule (on a longer line with many operators this can be confusing)
Is there anything you'd like reviewers to focus on?
?
or:
are not really an operators on their own, but i guess that's not a big deal.