docs: IA Update page URL move #16665
Conversation
eslint-github-bot
bot
added
the
triage
|
Hi @bpmutter!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by running Read more about contributing to ESLint here |
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
docs/src/static/robots.njk
Outdated
| @@ -4,4 +4,3 @@ permalink: robots.txt | |||
| eleventyExcludeFromCollections: true | |||
| --- | |||
| User-agent: * | |||
| Disallow: / | |||
There was a problem hiding this comment.
Note
Remove this change before merge. needed for URL checkers to parse.
There was a problem hiding this comment.
This might actually be a mistake. I think we were supposed to remove Disallow: / once we went live.
There was a problem hiding this comment.
yeah i was confused by that.
it's like this on the prod site as well. in https://eslint.org/docs/latest/robots.txt, the contents are:
User-agent: *
Disallow: /upon discovering this, i was confused how google would index the eslint docs at all. but upon some investigation, found this page, which explains that google indexes if there are backlinks from other sites to this one, even if robots.txt disallows indexing.
wonder if keeping this change would improve SEO for the docs.
There was a problem hiding this comment.
This prevents crawling of https://latest--docs-eslint.netlify.app, https://docs-eslint.netlify.app, deploy previews and other URLs where robots.txt will be in the root, while having no effect on https://eslint.org/ since it isn't in the root there.
Try rebasing again. This branch is currently 18 commits behind |
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
|
@mdjermanovic comments resolved in 869a5c6 |
|
Looks good! I think you can now revert changes in |
|
As for merging this PR, how shall we proceed?
|
|
@mdjermanovic applied those 2 reversions. and regarding:
i think we should choose the 2nd option. i don't see an issue with that. and i can still start on some further docs changes, just based on top of the branch in this PR. and if there are any additional community docs contributions between now and the merge of this, we can tell them to put the changes on top of this PR's branch. i'll also be happy to help with merging these community changes, should there be any. |
|
I think we can do it right before the release 👍 |
There was a problem hiding this comment.
LGTM, thanks!
This should be merged right before the release.
Then, right after the release, eslint/eslint.org#388 should be merged.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.31.0` -> `8.32.0`](https://renovatebot.com/diffs/npm/eslint/8.31.0/8.32.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.32.0`](https://github.com/eslint/eslint/releases/tag/v8.32.0) [Compare Source](eslint/eslint@v8.31.0...v8.32.0) #### Features - [`fc20f24`](eslint/eslint@fc20f24) feat: add suggestions for redundant wrapping in prefer-regex-literals ([#​16658](eslint/eslint#16658)) (YeonJuan) #### Bug Fixes - [`b4f8329`](eslint/eslint@b4f8329) fix: ignore directives for no-fallthrough ([#​16757](eslint/eslint#16757)) (gfyoung) #### Documentation - [`17b65ad`](eslint/eslint@17b65ad) docs: IA Update page URL move ([#​16665](eslint/eslint#16665)) (Ben Perlmutter) - [`5981296`](eslint/eslint@5981296) docs: fix theme switcher button ([#​16752](eslint/eslint#16752)) (Sam Chen) - [`6669413`](eslint/eslint@6669413) docs: deploy prerelease docs under the `/docs/next/` path ([#​16541](eslint/eslint#16541)) (Nitin Kumar) - [`78ecfe0`](eslint/eslint@78ecfe0) docs: use inline code for rule options name ([#​16768](eslint/eslint#16768)) (Percy Ma) - [`fc2ea59`](eslint/eslint@fc2ea59) docs: Update README (GitHub Actions Bot) - [`762a872`](eslint/eslint@762a872) docs: Update README (GitHub Actions Bot) #### Chores - [`2952d6e`](eslint/eslint@2952d6e) chore: sync templates/\*.md files with issue templates ([#​16758](eslint/eslint#16758)) (gfyoung) - [`3e34418`](eslint/eslint@3e34418) chore: Add new issues to triage project ([#​16740](eslint/eslint#16740)) (Nicholas C. Zakas) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDIuNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMi43In0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1734 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
* docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * docs: use inline code for rule options name eslint/eslint#16768 * docs: ignore directives for no-fallthrough eslint/eslint#16757 * docs: IA Update page URL move eslint/eslint#16665 * update * feat: sync v8.31.0 (#94) * docs: User Guide Getting Started expansion * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: adjust some words * docs: Add function call example for no-undefined eslint/eslint#16712 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * update formatters * Apply suggestions from code review Co-authored-by: Strek <ssharishkumar@gmail.com> --------- Co-authored-by: Strek <ssharishkumar@gmail.com> * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: IA Update page URL move eslint/eslint#16665 --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
eslint-github-bot
bot
added
the
archived due to age
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
move page URLs to locations in the New IA and internal links to those pages.
Is there anything you'd like reviewers to focus on?
❗❗❗ Please Read Before Reviewing! ❗❗❗
While I think it'll be useful to do a manual check, given the large number of files and links, I found using automated link-checking tools helpful as well. I would recommend that the reviewers check using a tool as well. The tools are:
Once the changes have been approved the changes to the following files must be reverted:
docs/src/static/robots.njkdocs/src/_includes/layouts/base.htmlThese changes were made to let the link checker tools parse the staging site.
Also, this PR should be reviewed, merged, and deployed together with eslint/eslint.org#388. This PR is for the redirects associated with the IA changes.
Also, I'm not sure why but the PR says I have conflicting files (see below). Not sure why as I've rebased the changes on top of the current(edit: resolved)mainbranch. would appreciate any ideas on how to fix.