Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync v8.32.0 #95

Merged
merged 9 commits into from Feb 28, 2023
Merged

feat: sync v8.32.0 #95

merged 9 commits into from Feb 28, 2023

Conversation

kecrily
Copy link
Member

@kecrily kecrily commented Feb 20, 2023

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

sync v8.32.0

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for zh-hans-docs ready!

Name Link
🔨 Latest commit 11a79dd
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-docs/deploys/63fd943315836300086783c7
😎 Deploy Preview https://deploy-preview-95--zh-hans-docs.netlify.app/rules/no-underscore-dangle
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kecrily kecrily added documentation Improvements or additions to documentation accepted and removed triage labels Feb 20, 2023
@nzakas nzakas mentioned this pull request Feb 20, 2023
1 task
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/extend/custom-rules.md, line 166, we should remove .md from (./scope-manager-interface.md#scope-interface).

(this was included in eslint/eslint@v8.31.0...v8.32.0)

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when #95 (review) is addressed. Feel free to merge this how you think it would be best in combination with #94.

kecrily and others added 9 commits February 28, 2023 13:41
* docs: User Guide Getting Started expansion

* docs: add options to check destructuring in no-underscore-dangle

eslint/eslint#16006

* docs: adjust some words

* docs: Add function call example for no-undefined

eslint/eslint#16712

* docs: check assignment patterns in no-underscore-dangle

eslint/eslint#16693

* update formatters

* Apply suggestions from code review

Co-authored-by: Strek <ssharishkumar@gmail.com>

---------

Co-authored-by: Strek <ssharishkumar@gmail.com>
@kecrily kecrily merged commit db64486 into latest Feb 28, 2023
@kecrily kecrily deleted the sync/8.32.0 branch February 28, 2023 05:45
GaliMu added a commit to GaliMu/zh-hans.docs.eslint.org that referenced this pull request Apr 11, 2023
GaliMu added a commit to GaliMu/zh-hans.docs.eslint.org that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted documentation Improvements or additions to documentation feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants