Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eslint-plugin-eslint-plugin@2.0.1 #11220

Merged
merged 2 commits into from Jan 4, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Expand Up @@ -21,6 +21,7 @@ module.exports = {
"eslint-plugin/prefer-output-null": "error",
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/report-message-format": ["error", "[^a-z].*\\.$"],
"eslint-plugin/require-meta-type": "error",
"eslint-plugin/test-case-property-ordering": "error",
"eslint-plugin/test-case-shorthand-strings": "error",
"rulesdir/multiline-comment-style": "error"
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/block-spacing.js
Expand Up @@ -29,8 +29,8 @@ module.exports = {
],

messages: {
missing: "Requires a space {{location}} '{{token}}'",
extra: "Unexpected space(s) {{location}} '{{token}}'"
missing: "Requires a space {{location}} '{{token}}'.",
extra: "Unexpected space(s) {{location}} '{{token}}'."
}
},

Expand Down
4 changes: 2 additions & 2 deletions lib/rules/capitalized-comments.js
Expand Up @@ -137,8 +137,8 @@ module.exports = {
],

messages: {
unexpectedLowercaseComment: "Comments should not begin with a lowercase character",
unexpectedUppercaseComment: "Comments should not begin with an uppercase character"
unexpectedLowercaseComment: "Comments should not begin with a lowercase character.",
unexpectedUppercaseComment: "Comments should not begin with an uppercase character."
}
},

Expand Down
8 changes: 4 additions & 4 deletions lib/rules/func-name-matching.js
Expand Up @@ -92,10 +92,10 @@ module.exports = {
},

messages: {
matchProperty: "Function name `{{funcName}}` should match property name `{{name}}`",
matchVariable: "Function name `{{funcName}}` should match variable name `{{name}}`",
notMatchProperty: "Function name `{{funcName}}` should not match property name `{{name}}`",
notMatchVariable: "Function name `{{funcName}}` should not match variable name `{{name}}`"
matchProperty: "Function name `{{funcName}}` should match property name `{{name}}`.",
matchVariable: "Function name `{{funcName}}` should match variable name `{{name}}`.",
notMatchProperty: "Function name `{{funcName}}` should not match property name `{{name}}`.",
notMatchVariable: "Function name `{{funcName}}` should not match variable name `{{name}}`."
}
},

Expand Down
2 changes: 1 addition & 1 deletion lib/rules/max-classes-per-file.js
Expand Up @@ -32,7 +32,7 @@ module.exports = {
],

messages: {
maximumExceeded: "Number of classes per file must not exceed {{ max }}"
maximumExceeded: "Number of classes per file must not exceed {{ max }}."
}
},
create(context) {
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/prefer-object-spread.js
Expand Up @@ -226,8 +226,8 @@ module.exports = {
fixable: "code",

messages: {
useSpreadMessage: "Use an object spread instead of `Object.assign` eg: `{ ...foo }`",
useLiteralMessage: "Use an object literal instead of `Object.assign`. eg: `{ foo: bar }`"
useSpreadMessage: "Use an object spread instead of `Object.assign` eg: `{ ...foo }`.",
useLiteralMessage: "Use an object literal instead of `Object.assign`. eg: `{ foo: bar }`."
}
},

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -86,7 +86,7 @@
"coveralls": "^3.0.1",
"dateformat": "^3.0.3",
"ejs": "^2.6.1",
"eslint-plugin-eslint-plugin": "^1.4.1",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-rulesdir": "^0.1.0",
"eslint-release": "^1.2.0",
Expand Down
2 changes: 1 addition & 1 deletion tools/internal-rules/consistent-docs-description.js
Expand Up @@ -115,7 +115,7 @@ module.exports = {
category: "Internal",
recommended: false
},

type: "suggestion",
schema: []
},

Expand Down
2 changes: 1 addition & 1 deletion tools/internal-rules/consistent-docs-url.js
Expand Up @@ -94,7 +94,7 @@ module.exports = {
category: "Internal",
recommended: false
},

type: "suggestion",
schema: []
},

Expand Down
3 changes: 2 additions & 1 deletion tools/internal-rules/consistent-meta-messages.js
Expand Up @@ -65,8 +65,9 @@ module.exports = {
recommended: false
},
schema: [],
type: "suggestion",
messages: {
expectedMessages: "Expected `meta.messages` property"
expectedMessages: "Expected `meta.messages` property."
}
},

Expand Down
2 changes: 1 addition & 1 deletion tools/internal-rules/no-invalid-meta.js
Expand Up @@ -161,7 +161,7 @@ module.exports = {
category: "Internal",
recommended: false
},

type: "suggestion",
aladdin-add marked this conversation as resolved.
Show resolved Hide resolved
schema: []
},

Expand Down