New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: eslint-plugin-eslint-plugin@2.0.1 #11220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic changes LGTM, thanks!
Regarding rule types for internal rules: I think suggestion makes sense for most of them, but I left a suggestion on one that I think should be a problem. Let me know what you think. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closing and reopening to see if it'll wake up the CLA checker. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Not sure what's wrong with the CLA checker-- are you using a new e-mail address in some of your commits?
It looks like the second commit was made from within the GitHub UI, and it formatted the commit's author name differently. Since the email address is identical, we'll consider them to be the same. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
upgrade eslint-plugin-eslint-plugin@2.0.1, it mainly added a new rule: require-meta-type.
Is there anything you'd like reviewers to focus on?
thoughts on the types of internal rules?