New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add note about Node.js requiring SSL support (fixes #11413) #12475
Conversation
Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall the change be made in the user guide (https://github.com/eslint/eslint/blob/master/docs/user-guide/getting-started.md#installation-and-usage)?
Oh yeah, that’s a good idea |
Updated the getting started guide, too. At some point we should probably just have one location for this information, but this should be good enough for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the update! seems ready to go~~~
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)
I also removed the notice about the npm version as we always support the npm version shipping with the supported Node.js versions.
Is there anything you'd like reviewers to focus on?