Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: init error in extending recommended config (fixes #12707) #12738

Merged
merged 6 commits into from Apr 6, 2020
Merged

Fix: init error in extending recommended config (fixes #12707) #12738

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4020af6
Fix: error in extending recommended config (fixes #12707)
yeonjuan Jan 3, 2020
02f11ab
change to push
yeonjuan Jan 4, 2020
5622de9
add test cases
yeonjuan Jan 4, 2020
166465f
add test case
yeonjuan Jan 4, 2020
caf2bb5
fix typo, add test case
yeonjuan Jan 7, 2020
0f5b342
change to put eslint:recommended at the beginning.
yeonjuan Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/init/autoconfig.js
View file
Open in desktop
Expand Up @@ -319,7 +319,7 @@ class Registry {
* This will return a new config with `"extends": "eslint:recommended"` and
* only the rules which have configurations different from the recommended config.
* @param {Object} config config object
* @returns {Object} config object using `"extends": "eslint:recommended"`
* @returns {Object} config object using `"extends": ["eslint:recommended"]`
*/
function extendFromRecommended(config) {
const newConfig = Object.assign({}, config);
Expand All @@ -333,7 +333,7 @@ function extendFromRecommended(config) {
delete newConfig.rules[ruleId];
}
});
newConfig.extends = RECOMMENDED_CONFIG_NAME;
newConfig.extends = [RECOMMENDED_CONFIG_NAME];
yeonjuan marked this conversation as resolved.
Show resolved Hide resolved
return newConfig;
}

Expand Down