New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: init error in extending recommended config (fixes #12707) #12738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Can we test this somehow?
Thanks for adding tests for this! I just had a thought - would it make more sense to put Also, would it be possible to write an integration test or two for |
While I write an integration test code, So, It ends up with showing error messages below.
Is it intended? |
Sorry I missed this! That seems like a bug to me. Can you make a separate issue for that? |
Thanks for contributing! |
|
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fix #12707. It still has a
triage label
but I can reproduce itreproduced - https://github.com/yeonjuan/autoconfbug
Is there anything you'd like reviewers to focus on?
The cause of the problem is precisely what here mentioned.