Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: add enforceForJSX option to no-unused-expressions rule #14012

Merged
merged 11 commits into from Feb 10, 2021
Merged

Update: add enforceForJSX option to no-unused-expressions rule #14012

merged 11 commits into from Feb 10, 2021

Commits on Jan 18, 2021

  1. Update: no-unused-expression flags unused JSX 

    React's createElement call is side-effect free, as are most JSX pragmas.
An unused JSX element indicates a logic error in the same way any unused, side-effect free expression is.
This extension the no-unused-expression rule flags unused JSX elements unless the (new) allowJsx configuration option is set
    @duncanbeevers
    duncanbeevers committed Jan 18, 2021
    Copy the full SHA
    7af0f6b View commit details
    Browse the repository at this point in the history

  2. fixup! Update: no-unused-expression flags unused JSX 

    React's createElement call is side-effect free, as are most JSX pragmas.
An unused JSX element indicates a logic error in the same way any unused, side-effect free expression is.
This extension the no-unused-expression rule flags unused JSX elements when the (new) ignoreJSX configuration option is set
    @duncanbeevers
    duncanbeevers committed Jan 18, 2021
    Copy the full SHA
    a9b6c6a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 19, 2021
    Copy the full SHA
    851f799 View commit details
    Browse the repository at this point in the history

  2. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 19, 2021
    Copy the full SHA
    9e77c9d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 23, 2021
    Copy the full SHA
    9dd1418 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 30, 2021
    Copy the full SHA
    dc691b3 View commit details
    Browse the repository at this point in the history

  2. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 30, 2021
    Copy the full SHA
    b7aa0ea View commit details
    Browse the repository at this point in the history

  3. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 30, 2021
    Copy the full SHA
    4049ece View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Jan 31, 2021
    Copy the full SHA
    3d25242 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. fixup! Update: no-unused-expression flags unused JSX

    @duncanbeevers
    duncanbeevers committed Feb 1, 2021
    Copy the full SHA
    9a92841 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. fixup! Update: no-unused-expression flags unused JSX 

    Apply suggestions from code review

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @duncanbeevers @mdjermanovic
    duncanbeevers and mdjermanovic committed Feb 3, 2021
    Copy the full SHA
    3895b79 View commit details
    Browse the repository at this point in the history