New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add enforceForJSX option to no-unused-expressions rule #14012
Merged
mdjermanovic
merged 11 commits into
eslint:master
from
duncanbeevers:no-unused-expression-jsx
Feb 10, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7af0f6b
Update: no-unused-expression flags unused JSX
duncanbeevers a9b6c6a
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 851f799
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 9e77c9d
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 9dd1418
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers dc691b3
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers b7aa0ea
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 4049ece
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 3d25242
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 9a92841
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers 3895b79
fixup! Update: no-unused-expression flags unused JSX
duncanbeevers File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @duncanbeevers, I forgot about the examples of correct and incorrect code with each option below. Can you add those for this new option? That'd be a fine place to explain that people can enable this option if JSX has no side effects as in React. (Thanks @mdjermanovic for catching my mistake.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I considered adding those, but I thought they might be superfluous. I really don't want this PR to add a lot of noise, and I especially want to make sure anything public-facing gets explicit consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added examples and a little descriptive text about JSX pragmas. I'm still concerned about being too low-level, and really want something sweet, simple, and that clearly indicates to the 99.9999% of JSX users that they should turn this on.