Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add node v19 #16443

Merged
merged 1 commit into from Oct 20, 2022
Merged

build: add node v19 #16443

merged 1 commit into from Oct 20, 2022

Commits on Oct 20, 2022

  1. build: add node v19

    Node v19.0.0 has been released.
    https://nodejs.org/en/blog/release/v19.0.0/
    
    This PR adds the v19 matrix and fixes the following tests failure when using v19.0.0.
    
    ```console
    % node -v
    v19.0.0
    % npx mocha tests/lib/shared/runtime-info.js
    (snip)
    
    1) RuntimeInfo
         environment()
           log and throw an error when checking for local ESLint version when returned output of command is malformed:
    
        AssertionError: expected [Function environment] to throw error including 'Unexpected token T in JSON at positio…' but got 'Unexpected token \'T\', "This is not …'
        + expected - actual
    
        -Unexpected token 'T', "This is not JSON" is not valid JSON
        +Unexpected token T in JSON at position 0
    
        at Context.<anonymous> (tests/lib/shared/runtime-info.js:209:20)
        at process.processImmediate (node:internal/timers:471:21)
    
    2) RuntimeInfo
         environment()
           log and throw an error when checking for global ESLint version when returned output of command is malformed:
    
        AssertionError: expected [Function environment] to throw error including 'Unexpected token T in JSON at positio…' but got 'Unexpected token \'T\', "This is not …'
        + expected - actual
    
        -Unexpected token 'T', "This is not JSON" is not valid JSON
        +Unexpected token T in JSON at position 0
    
        at Context.<anonymous> (tests/lib/shared/runtime-info.js:217:20)
        at process.processImmediate (node:internal/timers:471:21)
    ```
    
    This patch uses regexp to match both messages because the message has changed in v19.0.0.
    koic committed Oct 20, 2022
    Copy the full SHA
    e6842cc View commit details
    Browse the repository at this point in the history