Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add node v19 #16443

Merged
merged 1 commit into from Oct 20, 2022
Merged

build: add node v19 #16443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [18.x, 17.x, 16.x, 14.x, 12.x, "12.22.0"]
node: [19.x, 18.x, 17.x, 16.x, 14.x, 12.x, "12.22.0"]
include:
- os: windows-latest
node: "16.x"
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/shared/runtime-info.js
View file
Open in desktop
Expand Up @@ -206,15 +206,15 @@ describe("RuntimeInfo", () => {
spawnSyncStubArgs[2] = "This is not JSON";
setupSpawnSyncStubReturnVals(spawnSyncStub, spawnSyncStubArgs);

assert.throws(RuntimeInfo.environment, "Unexpected token T in JSON at position 0");
assert.throws(RuntimeInfo.environment, /^Unexpected token .*T.* JSON/u);
assert.strictEqual(logErrorStub.args[0][0], "Error finding eslint version running the command `npm ls --depth=0 --json eslint`");
});

it("log and throw an error when checking for global ESLint version when returned output of command is malformed", () => {
spawnSyncStubArgs[4] = "This is not JSON";
setupSpawnSyncStubReturnVals(spawnSyncStub, spawnSyncStubArgs);

assert.throws(RuntimeInfo.environment, "Unexpected token T in JSON at position 0");
assert.throws(RuntimeInfo.environment, /^Unexpected token .*T.* JSON/u);
assert.strictEqual(logErrorStub.args[0][0], "Error finding eslint version running the command `npm ls --depth=0 --json eslint -g`");
});
});
Expand Down