Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MQTT docs to include discover_ip option #3809

Open
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

Links2004
Copy link

Description:

Pull request in esphome with YAML changes (if applicable): esphome/esphome#6673

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 8924c97
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/66518ced06ebf400089181f6
😎 Deploy Preview https://deploy-preview-3809--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nitpicks (mostly), but otherwise lgtm

components/mqtt.rst Outdated Show resolved Hide resolved
components/mqtt.rst Outdated Show resolved Hide resolved
components/mqtt.rst Show resolved Hide resolved
components/mqtt.rst Outdated Show resolved Hide resolved
components/mqtt.rst Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft May 10, 2024 22:39
@esphome
Copy link

esphome bot commented May 10, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Links2004 and others added 3 commits May 11, 2024 10:02
Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
@Links2004 Links2004 marked this pull request as ready for review May 11, 2024 08:06
@esphome esphome bot requested a review from kbx81 May 11, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants