-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MQTT ip discovery to deticated config option. #6673
Open
Links2004
wants to merge
9
commits into
esphome:dev
Choose a base branch
from
Links2004:mqtt_discover_ip
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6673 +/- ##
==========================================
+ Coverage 53.70% 54.13% +0.42%
==========================================
Files 50 50
Lines 9408 9619 +211
Branches 1654 1698 +44
==========================================
+ Hits 5053 5207 +154
- Misses 4056 4086 +30
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
Links2004
force-pushed
the
mqtt_discover_ip
branch
from
May 3, 2024 14:22
13c1133
to
fef10a9
Compare
This allows to disable entity discovery and only keep the IP discovery. With this its possible to discover devices with API enabled on Home Assistant (home-assistant/core#116499) when there is no mDNS possible.
Links2004
force-pushed
the
mqtt_discover_ip
branch
from
May 3, 2024 15:06
fef10a9
to
e392621
Compare
3 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This allows to disable entity discovery and only keep the IP discovery.
With this change its possible to discover devices with API enabled on Home Assistant (home-assistant/core#116499) when there is no mDNS possible.
Types of changes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3809
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: