add Dynamic Imports and BigInt as ES2020 #198

mysticatea · 2019-06-04T13:58:29Z

tc39/proposals@b04295f

BigInt to stage 4 tc39/proposals#217 (the meeting notes have the conclusion "Stage 4 acceptance")

Dynamic Imports and BigInt syntaxes have arrived at Stage 4. This PR adds those syntaxes as ES2020.

es2020.md

I extended Literal as separated from BigIntLiteral because of consistent. Literal has RegExp value and RegExpLiteral extends only regex property.
[EDIT] I represented Dynamic Imports as CallExpression as same as the current experimental spec. However, I think that another way such as ImportExpression is better: Revisit Dynamic Imports #197. Thoughts? I changed the AST of Dynamic Imports because of Revisit Dynamic Imports #197. I believe that the Import node way will confuse us in the future.

Fixes #197, fixes #169, closes #179.

adrianheine · 2019-06-04T18:58:48Z

There's already #179 for BigInts (but I don't care which one is merged). I'm still in favor of not having value for them in the spec.

mysticatea · 2019-06-04T19:45:24Z

Because that was adding the spec into experimental directory, I have written this to move both syntaxes to es2020.md.

I prefer having value. The Literal node has value property, so the derived interface must have value property. We have experienced this behavior already when new syntaxes were added in RegExp. Indeed, nullable is odd, but I'm not worried because it's temporary.

michaelficarra · 2019-06-04T21:24:41Z

@mysticatea In a bunch of places, you've mistyped BigInt as BitInt.

es2020.md

mysticatea · 2019-06-04T22:50:58Z

I'm leaning toward, we should change the representation of dynamic imports: #197.

mysticatea · 2019-06-08T18:06:45Z

What should I do to advance this PR?

mysticatea · 2019-06-11T12:52:34Z

@RReverser @ariya would you take a look this PR?

es2020.md

mysticatea · 2019-06-16T16:50:33Z

What should I do to advance this PR?

RReverser

Looks reasonable to me overall.

mercmobily · 2019-06-27T05:37:16Z

Are ther any more steps needed/revisions before this PR can be merged? Adding this in case this slipped

mercmobily · 2019-06-27T05:39:40Z

I am typing here as ESlint depends on this to get dynamic imports happening!

eslint/eslint#11803

aladdin-add · 2019-06-29T14:17:52Z

any news?

RReverser · 2019-06-29T17:05:25Z

@adrianheine Still would like your input on your PR vs this one.

mikesherov · 2019-07-11T02:47:31Z

I don't think we can land this as is. Unless I'm mistaken, both Webpack and Acorn have adopted the current experimental design for dynamic import. Seems it's too late and not worth the effort to undo the change. Just my 2 cents here.

mysticatea · 2019-07-11T03:10:23Z

I know Acorn's release was a mistake. I think they will make a major release after this PR merged. (acornjs/acorn#834 (comment))

mikesherov · 2019-07-11T10:53:25Z

@mysticatea and what about Webpack? This would need to get merged and released before Webpack 5 was released.

mysticatea · 2019-07-11T11:31:18Z

The AST was experimental. I believe we should fix it before getting stable, rather than leaving the pain for the future.

This would need to get merged and released before Webpack 5 was released.

I hope this PR to be merged as soon as possible. I have been waiting for the decide of ESTree team since a month ago. I'm just waiting.

mikesherov · 2019-07-11T11:53:07Z

ok, so:

Approvals needed:
[x] @mysticatea I suppose you serve as approval from the ESLint side of things.
[x] @RReverser speaks for Acorn.
[ ] @adrianheine still waiting on your approval as per @RReverser's comment.
[x] @michaelficarra you've reviewed. Would be nice to get an explicit approval from you.

People to inform:

Pinging @sokra as a heads up that there will be an AST change coming up to hopefully get it into Webpack 5.
And pinging @hzoo on the Babel side of things that this change is coming.

mikesherov

Not that my approval matters as an inactive member, but just figured one more couldn't hurt.

aladdin-add · 2019-07-20T04:27:08Z

friendly ping @adrianheine

mysticatea · 2019-07-21T21:57:48Z

We have over a month (40 days) since the last commit. Is there any chance to be merged?

mikesherov · 2019-07-22T13:00:22Z

@RReverser I think we should merge this one and also credit @adrianheine in the commit message. The two pull requests are fundamentally the same thing (with respect to BigInt), no? Alternatively, we could land the dynamic import stuff (since we have wide agreement here), and slice off BigInt until Adrian replies.

Either way it's time to move this forward :-)

mikesherov · 2019-07-29T12:48:12Z

@RReverser once you're settled in at your new gig, perhaps you can merge this PR, or are we still waiting on anyone?

Align with estree/estree#198

mysticatea · 2019-08-12T11:15:35Z

We have over two months since the last commit. Is there any chance to be merged?

mikesherov · 2019-08-12T12:22:07Z

Thanks @RReverser! @mysticatea do have any PRs open against Acorn acknowledging this change?

mysticatea · 2019-08-12T12:27:14Z

Thank you for merged!

Yes, I have acornjs/acorn#844

mikesherov · 2019-08-12T13:24:17Z

FYI, I've also pinged @sokra about the change so hopefully it can land in Acorn before Webpack 5.

* Add support for dynamic Import expressions. See https://tc39.github.io/proposal-dynamic-import/ * Added skipped failing tests for dynamic import. Tests depend on espree supporting dynamic import * Update dynamic import test with literal parse tree instead of depending on espree having dynamic import support * Align with estree/estree#198

* feat: support dynamic import * Add a couple of tests * Align with estree/estree#198 * Update escodegen.js Co-Authored-By: Michael Ficarra <github@michael.ficarra.me> * Remove outdated "State 3" from comment * Add test of a SequenceExpression as a dynamic import source #395 (comment) * Properly parenthesize when used with a higher precedence operator #395 (comment)

mikesherov · 2019-08-18T23:06:15Z

Just for record keeping:
This has landed in Acorn 7.0.0 and will be in Webpack 5 alpha 21.

* feat: support dynamic import * Add a couple of tests * Align with estree/estree#198 * Update escodegen.js Co-Authored-By: Michael Ficarra <github@michael.ficarra.me> * Remove outdated "State 3" from comment * Add test of a SequenceExpression as a dynamic import source estools#395 (comment) * Properly parenthesize when used with a higher precedence operator estools#395 (comment)

add Dynamic Imports and BigInt as ES2020

0e30ec7

This was referenced Jun 4, 2019

Dynamic Imports and BigInt have arrived at Stage 4 🎉 eslint/eslint#11803

Closed

Please support dynamic imports and BigInt (Stage 4) acornjs/acorn#833

Closed

michaelficarra reviewed Jun 4, 2019

View reviewed changes

es2020.md Outdated Show resolved Hide resolved

fix typos

1897821

mysticatea added 2 commits June 5, 2019 08:18

make bigint property not including n

62859d7

change dynamic imports AST

a7ed03d

michaelficarra reviewed Jun 11, 2019

View reviewed changes

es2020.md Outdated Show resolved Hide resolved

michaelficarra reviewed Jun 11, 2019

View reviewed changes

es2020.md Show resolved Hide resolved

fix typo

167a8a8

RReverser approved these changes Jun 17, 2019

View reviewed changes

aladdin-add approved these changes Jul 3, 2019

View reviewed changes

mysticatea mentioned this pull request Jul 4, 2019

Add dynamic import acornjs/acorn#834

Closed

mikesherov approved these changes Jul 11, 2019

View reviewed changes

michaelficarra approved these changes Jul 11, 2019

View reviewed changes

This was referenced Jul 13, 2019

Update dynamic imports AST acornjs/acorn#844

Merged

Update: add ImportExpression eslint/eslint-visitor-keys#8

Merged

michaelficarra mentioned this pull request Aug 5, 2019

Support dynamic import (take 2) estools/escodegen#395

Merged

1 task

papandreou added a commit to papandreou/escodegen that referenced this pull request Aug 5, 2019

Align with estree/estree#198

9fd6e34

papandreou added a commit to papandreou/estraverse that referenced this pull request Aug 5, 2019

Align with estree/estree#198

f5157e4

Munter added a commit to Munter/estraverse that referenced this pull request Aug 5, 2019

Merge pull request #1 from papandreou/support-dynamic-import

2bf769f

Align with estree/estree#198

papandreou added a commit to assetgraph/assetgraph that referenced this pull request Aug 11, 2019

Align with estree/estree#198

8379ae3

papandreou mentioned this pull request Aug 11, 2019

JavaScriptDynamicImport relation (BLOCKED) assetgraph/assetgraph#1003

Merged

6 tasks

RReverser merged commit 9a38106 into estree:master Aug 12, 2019

mysticatea deleted the update-june-2019 branch August 12, 2019 12:27

papandreou mentioned this pull request Aug 12, 2019

Support dynamic import estools/estraverse#100

Merged

benjamn mentioned this pull request Mar 27, 2020

Add ImportExpression node type (ES2020) benjamn/ast-types#365

Merged

snyk-bot mentioned this pull request Jan 13, 2022

[Snyk] Fix for 32 vulnerabilities DavidKindler/es6-angularjs#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Dynamic Imports and BigInt as ES2020 #198

add Dynamic Imports and BigInt as ES2020 #198

mysticatea commented Jun 4, 2019 •

edited

adrianheine commented Jun 4, 2019

mysticatea commented Jun 4, 2019

michaelficarra commented Jun 4, 2019

mysticatea commented Jun 4, 2019

mysticatea commented Jun 8, 2019

mysticatea commented Jun 11, 2019

mysticatea commented Jun 16, 2019

RReverser left a comment

mercmobily commented Jun 27, 2019

mercmobily commented Jun 27, 2019

aladdin-add commented Jun 29, 2019

RReverser commented Jun 29, 2019

mikesherov commented Jul 11, 2019

mysticatea commented Jul 11, 2019 •

edited

mikesherov commented Jul 11, 2019

mysticatea commented Jul 11, 2019

mikesherov commented Jul 11, 2019 •

edited

mikesherov left a comment

aladdin-add commented Jul 20, 2019

mysticatea commented Jul 21, 2019

mikesherov commented Jul 22, 2019

mikesherov commented Jul 29, 2019

mysticatea commented Aug 12, 2019

mikesherov commented Aug 12, 2019

mysticatea commented Aug 12, 2019

mikesherov commented Aug 12, 2019

mikesherov commented Aug 18, 2019

add Dynamic Imports and BigInt as ES2020 #198

add Dynamic Imports and BigInt as ES2020 #198

Conversation

mysticatea commented Jun 4, 2019 • edited

adrianheine commented Jun 4, 2019

mysticatea commented Jun 4, 2019

michaelficarra commented Jun 4, 2019

mysticatea commented Jun 4, 2019

mysticatea commented Jun 8, 2019

mysticatea commented Jun 11, 2019

mysticatea commented Jun 16, 2019

RReverser left a comment

Choose a reason for hiding this comment

mercmobily commented Jun 27, 2019

mercmobily commented Jun 27, 2019

aladdin-add commented Jun 29, 2019

RReverser commented Jun 29, 2019

mikesherov commented Jul 11, 2019

mysticatea commented Jul 11, 2019 • edited

mikesherov commented Jul 11, 2019

mysticatea commented Jul 11, 2019

mikesherov commented Jul 11, 2019 • edited

mikesherov left a comment

Choose a reason for hiding this comment

aladdin-add commented Jul 20, 2019

mysticatea commented Jul 21, 2019

mikesherov commented Jul 22, 2019

mikesherov commented Jul 29, 2019

mysticatea commented Aug 12, 2019

mikesherov commented Aug 12, 2019

mysticatea commented Aug 12, 2019

mikesherov commented Aug 12, 2019

mikesherov commented Aug 18, 2019

mysticatea commented Jun 4, 2019 •

edited

mysticatea commented Jul 11, 2019 •

edited

mikesherov commented Jul 11, 2019 •

edited