Install plugins via .wp-env.json for e2e testing. #709

nicolad · 2021-02-08T09:56:00Z

Related: #689

nicolad · 2021-02-08T11:57:12Z

package.json

@@ -163,7 +164,7 @@
 		"mini-css-extract-plugin": "1.3.4",
 		"npm-check": "^5.9.2",
 		"optimize-css-assets-webpack-plugin": "5.0.4",
-		"playwright": "^1.8.0",
+		"playwright": "^1.7.0",


as seen here

nicolad · 2021-02-08T16:35:19Z

.wp-env.json

@@ -3,7 +3,7 @@
 	"env": {
 		"tests": {
 			"mappings": {
-				"wp-content/plugins/event-espresso-core": "./build",


based on uploaded artifact, the build folder is for barista

nicolad · 2021-02-08T19:32:45Z

.github/workflows/pr-checks.yml

@@ -72,12 +73,24 @@ jobs:
            - name: Setup Playwright
              uses: microsoft/playwright-github-action@v1

+            - name: Check out event-espresso-core
+              uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675


tried as suggested here: actions/checkout#417 (comment)

nicolad · 2021-02-08T19:33:03Z

.gitignore

@@ -72,3 +72,5 @@ typings/

 # SB-related
 storybook-static
+
+event-espresso-core


tried this: actions/checkout#424 (comment)

nicolad · 2021-02-08T19:33:25Z

.github/workflows/pr-checks.yml

+                  GIT_TRACE: 1
+                  GIT_CURL_VERBOSE: 1


to make it more verbose

nicolad · 2021-02-09T16:10:30Z

.github/workflows/pr-checks.yml

@@ -66,6 +67,18 @@ jobs:
            - name: Make sure PlayWright doesn't play it wrong
              run: yarn add -WD playwright

+            - name: Check out event-espresso-core


the errors I had before was related to the order of this step, it needs to be before WP install

really? that... doesn't make any sense...
if WP isn't installed then there's no /wp-content/plugins/ folder to put the EE plugin into !!?!?!

in .wp-env.json we have mappings to corresponding plugin

from https://developer.wordpress.org/block-editor/packages/packages-env/

my point was that how do you install EE (a WP plugin) before WP is installed?

I tried to add the EE after WP installation, but was getting a lot of permission issues, so tried this way and it was working;
I am not aware of wordress/env internals and can't tell how this is installed internally into that docker container, my guess would be that they feed somehow the mappings after the install process automagically 🤷‍♂️

nicolad · 2021-02-09T16:11:04Z

.github/workflows/pr-checks.yml

+            - name: Build event-espresso-core
+              run: cd event-espresso-core && yarn && yarn build


not entirely happy with this approach, but I was getting the error that there is no manifest file

if GitHub ever adds composite actions then we'll need to build one that handles all of the WP && EE core setup.

@manzoorwanijk can we cache things at any point during a workflow and reuse in another step?
would be great if we could cache the initial WP && EE Core setup.

Yes, we can. But it's better to wait for composite actions

nicolad · 2021-02-09T16:28:06Z

packages/e2e-tests/specs/hello.test.ts

+	it('should work', async () => {
+		await loginUser();
+
+		await activatePlugin('event-espresso');


locally and on CI, the core plugin has this slug

tn3rb

COOL 😎

other than some missing newlines at the end of some PHP files, everything looks great to me!

tn3rb · 2021-02-09T16:47:10Z

.github/workflows/pr-checks.yml

@@ -66,6 +67,18 @@ jobs:
            - name: Make sure PlayWright doesn't play it wrong
              run: yarn add -WD playwright

+            - name: Check out event-espresso-core


really? that... doesn't make any sense...
if WP isn't installed then there's no /wp-content/plugins/ folder to put the EE plugin into !!?!?!

tn3rb · 2021-02-09T16:49:18Z

.github/workflows/pr-checks.yml

+            - name: Build event-espresso-core
+              run: cd event-espresso-core && yarn && yarn build


if GitHub ever adds composite actions then we'll need to build one that handles all of the WP && EE core setup.

@manzoorwanijk can we cache things at any point during a workflow and reuse in another step?
would be great if we could cache the initial WP && EE Core setup.

tn3rb · 2021-02-09T16:52:02Z

packages/e2e-tests/plugins/disable-animations.php

+	wp_add_inline_style( 'wp-components', $custom_css );
+}
+
+add_action( 'admin_enqueue_scripts', 'enqueue_disable_animations_stylesheet' );


ooo i didn't know you were a php dev too?!?!?

looks like you need newlines at the end of these php files though

no, just borrowed this from GB,
added newline

tn3rb · 2021-02-09T16:54:13Z

packages/e2e-tests/specs/hello.test.ts

+
+		await activatePlugin('event-espresso');
+
+		expect(true).toBe(true);


🤔

verifying that the booleans haven't been redefined?

oops, there were no assertions while debugging and I've added an expect just to please jest

nicolad added the C: build process 🔨 category label Feb 8, 2021

nicolad self-assigned this Feb 8, 2021

nicolad added this to In progress in Barista CI/CD Pipeline via automation Feb 8, 2021

nicolad force-pushed the e2e-improvements branch 4 times, most recently from 5a9a898 to 914ef21 Compare February 8, 2021 11:54

nicolad commented Feb 8, 2021

View reviewed changes

nicolad force-pushed the e2e-improvements branch 8 times, most recently from b384a18 to e69009b Compare February 8, 2021 16:14

nicolad commented Feb 8, 2021

View reviewed changes

nicolad force-pushed the e2e-improvements branch 6 times, most recently from daadc40 to 1940f23 Compare February 8, 2021 19:07

nicolad commented Feb 8, 2021

View reviewed changes

nicolad added 4 commits February 9, 2021 15:13

Added .wp-env.json

1e8da50

Updated WP_BASE_URL.

9bdfab9

Small improvement.

008a569

Added event-espresso via wp-env json.

edde621

nicolad added 4 commits February 9, 2021 15:13

Added gutenberg-test-plugin-nonce.

269b848

Small improvement.

84ef5ca

Small improvement.

5004fb0

Added check out event-espresso-core.

0307e5c

nicolad force-pushed the e2e-improvements branch 2 times, most recently from 8999e99 to ba305f4 Compare February 9, 2021 13:53

nicolad added 2 commits February 9, 2021 15:56

Added token to checkout step in PR check workflow.

b390e20

Added persist-credentials

f835264

nicolad force-pushed the e2e-improvements branch from ba305f4 to f835264 Compare February 9, 2021 13:56

nicolad added 2 commits February 9, 2021 16:09

Small improvement.

970c047

Cloned folder renaming.

3999ae4

nicolad commented Feb 9, 2021

View reviewed changes

nicolad force-pushed the e2e-improvements branch 2 times, most recently from cd3ee63 to 29a7291 Compare February 9, 2021 16:14

nicolad commented Feb 9, 2021

View reviewed changes

nicolad marked this pull request as ready for review February 9, 2021 16:28

nicolad requested review from manzoorwanijk and tn3rb February 9, 2021 16:28

nicolad moved this from In progress to Code Review in Barista CI/CD Pipeline Feb 9, 2021

tn3rb previously approved these changes Feb 9, 2021

View reviewed changes

nicolad dismissed tn3rb’s stale review via a6dacd5 February 9, 2021 16:57

nicolad force-pushed the e2e-improvements branch from 65f6e0d to a6dacd5 Compare February 9, 2021 16:57

Small improvement.

a6ec6c9

nicolad force-pushed the e2e-improvements branch from a6dacd5 to a6ec6c9 Compare February 9, 2021 18:16

nicolad requested a review from tn3rb February 9, 2021 18:16

tn3rb approved these changes Feb 9, 2021

View reviewed changes

nicolad merged commit eea25bd into master Feb 9, 2021

Barista CI/CD Pipeline automation moved this from Code Review to Done Feb 9, 2021

nicolad deleted the e2e-improvements branch February 9, 2021 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install plugins via .wp-env.json for e2e testing. #709

Install plugins via .wp-env.json for e2e testing. #709

nicolad commented Feb 8, 2021

nicolad Feb 8, 2021

nicolad Feb 8, 2021

nicolad Feb 8, 2021

nicolad Feb 8, 2021

nicolad Feb 8, 2021

nicolad Feb 9, 2021

tn3rb Feb 9, 2021

nicolad Feb 9, 2021

nicolad Feb 9, 2021

tn3rb Feb 9, 2021

nicolad Feb 9, 2021

nicolad Feb 9, 2021

tn3rb Feb 9, 2021

manzoorwanijk Feb 9, 2021

nicolad Feb 9, 2021

tn3rb left a comment

tn3rb Feb 9, 2021

tn3rb Feb 9, 2021

tn3rb Feb 9, 2021

nicolad Feb 9, 2021

tn3rb Feb 9, 2021

nicolad Feb 9, 2021

		- name: Build event-espresso-core
		run: cd event-espresso-core && yarn && yarn build


		await activatePlugin('event-espresso');

		expect(true).toBe(true);

Install plugins via .wp-env.json for e2e testing. #709

Install plugins via .wp-env.json for e2e testing. #709

Conversation

nicolad commented Feb 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tn3rb left a comment

Choose a reason for hiding this comment

COOL 😎

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

🤔

Choose a reason for hiding this comment