Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃攢 MERGE: Synchronize with markdown-it v12.0.4 #140

Merged
merged 16 commits into from
Mar 10, 2021
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Mar 10, 2021

This is a reworking of #110, but with commits split to mirror those in markdown-it

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #140 (5417b21) into master (09edd66) will increase coverage by 0.23%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   96.27%   96.51%   +0.23%     
==========================================
  Files          72       72              
  Lines        3141     3185      +44     
==========================================
+ Hits         3024     3074      +50     
+ Misses        117      111       -6     
Flag Coverage 螖
pytests 96.51% <97.36%> (+0.23%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
markdown_it/common/html_blocks.py 100.00% <酶> (酶)
markdown_it/rules_inline/strikethrough.py 97.40% <酶> (酶)
markdown_it/rules_inline/balance_pairs.py 98.14% <66.66%> (-1.86%) 猬囷笍
markdown_it/helpers/parse_link_destination.py 96.66% <83.33%> (-1.49%) 猬囷笍
markdown_it/renderer.py 98.21% <85.71%> (+1.04%) 猬嗭笍
markdown_it/common/html_re.py 100.00% <100.00%> (酶)
markdown_it/helpers/parse_link_title.py 97.61% <100.00%> (+0.11%) 猬嗭笍
markdown_it/rules_block/table.py 100.00% <100.00%> (+1.45%) 猬嗭笍
markdown_it/rules_inline/autolink.py 96.29% <100.00%> (+0.46%) 猬嗭笍
markdown_it/rules_inline/backticks.py 100.00% <100.00%> (酶)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 09edd66...5417b21. Read the comment docs.

To comply with markdown-it/markdown-it@f156ed1
Although this test is currently skipped and requires fixing
The highligh callback should not have the signature: `highlight(code, lang, attrs)`.
Implements: markdown-it/markdown-it@866fba3
Alter code such that parsing respects: https://github.github.com/gfm/#tables-extension-

 - table now doesn't deal with backticks at all
 - `|` is considered escaped if and only if there is a `\` character immediately before it
 - number of elements in the first row (thead) now must match second row (aligns) exactly
 - no `tbody` if it would be empty

Implements: markdown-it/markdown-it@3021a52
- Fix tables inside lists indented with tabs  (implements: markdown-it/markdown-it@75fe6e0)
- Table with no columns is no longer a table (implements: markdown-it/markdown-it@b56eeb0)
- Disallow escaped spaces inside link destination: `[](url\ xxx)` no longer valid (implements: markdown-it/markdown-it@2290e10)
-  Stop link title parsing when second `(` is found: `[](url (xxx())` no longer valid (implements: markdown-it/markdown-it@b1651b1)
- Stop link parsing when second `<` is found: `[](<foo<bar>)` (implements: markdown-it/markdown-it@f688abc)
Adds a cache `StateInline->backticks` which remembers
positions for every possible backtick closer.

The algorithm is similar to the one described here: mity/md4c@685b714

Implements: markdown-it/markdown-it@1e8aff0 and markdown-it/markdown-it@fece91e
Don't try to parse link title if link wasn't found  (implements: markdown-it/markdown-it@537ab89)

Allow no more than 32 levels of nesting in `[]( (((((....))))) )` (implements: markdown-it/markdown-it@1910a3c)
Fix quadratic complexity in autolinks

implements: markdown-it/markdown-it@e729b90
@chrisjsewell chrisjsewell marked this pull request as ready for review March 10, 2021 12:57
@chrisjsewell chrisjsewell merged commit 29a8d5e into master Mar 10, 2021
@chrisjsewell chrisjsewell deleted the update-port branch March 10, 2021 13:05
chrisjsewell added a commit that referenced this pull request Mar 10, 2021
Fix a few mistaken regressions from #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant