Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] add skip credentials flag #1702

Merged
merged 2 commits into from Mar 19, 2020
Merged

[cli] add skip credentials flag #1702

merged 2 commits into from Mar 19, 2020

Conversation

quinlanj
Copy link
Member

why

  • add support for a user to skip checking credentials if they are sure they have everything configured properly. Use case: credentials checking can take some time, and people who run builds frequently will want to skip checks

tests

  • credentials checking runs with no flag set
  • credentials checking is skipped when flag is set

@quinlanj quinlanj requested a review from wkozyra95 March 18, 2020 19:48
dsokal
dsokal reviewed Mar 19, 2020
View reviewed changes
packages/expo-cli/src/commands/build/index.ts
@@ -49,6 +49,7 @@ export default function(program: Command) {
'--public-url <url>',
'The URL of an externally hosted manifest (for self-hosted apps).'
)
.option('--skip-credentials-check', 'Skip checking credentials.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also hide this option from the help output. However, it looks like it's not possible to do it with commander yet - tj/commander.js#1106 :(

@quinlanj @dsokal
Update packages/expo-cli/src/commands/build/ios/IOSBuilder.ts
917730a 
Co-Authored-By: Dominik Sokal <dominik.sokal@swmansion.com>
@quinlanj quinlanj merged commit b641445 into master Mar 19, 2020
@quinlanj quinlanj deleted the @quin/skipCredentialsCheck branch March 19, 2020 23:02
cruzach pushed a commit that referenced this pull request Mar 24, 2020
@quinlanj @dsokal @cruzach
[cli] add skip credentials flag (#1702)
c3cb232 
* [cli] add skip credentials flag

* Update packages/expo-cli/src/commands/build/ios/IOSBuilder.ts

Co-Authored-By: Dominik Sokal <dominik.sokal@swmansion.com>

Co-authored-by: Dominik Sokal <dominik.sokal@swmansion.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsokal dsokal dsokal approved these changes

@wkozyra95 wkozyra95 wkozyra95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quinlanj @dsokal @wkozyra95