Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[cli] add skip credentials flag #1702

Merged
merged 2 commits into from
Mar 19, 2020
Merged

[cli] add skip credentials flag #1702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
811bdb8
[cli] add skip credentials flag
quinlanj Mar 18, 2020
917730a
Update packages/expo-cli/src/commands/build/ios/IOSBuilder.ts
quinlanj Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/expo-cli/src/commands/build/BaseBuilder.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export type IosOptions = CommonOptions & {
pushId?: string;
pushP8Path?: string;
provisioningProfilePath?: string;
skipCredentialsCheck?: boolean;
};

export type AndroidOptions = CommonOptions & {
Expand Down
1 change: 1 addition & 0 deletions packages/expo-cli/src/commands/build/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default function(program: Command) {
'--public-url <url>',
'The URL of an externally hosted manifest (for self-hosted apps).'
)
.option('--skip-credentials-check', 'Skip checking credentials.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also hide this option from the help output. However, it looks like it's not possible to do it with commander yet - tj/commander.js#1106 :(

.description(
'Build a standalone IPA for your project, signed and ready for submission to the Apple App Store.'
)
Expand Down
7 changes: 7 additions & 0 deletions packages/expo-cli/src/commands/build/ios/IOSBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ See https://docs.expo.io/versions/latest/distribution/building-standalone-apps/#
await this.clearAndRevokeCredentialsIfRequested(context, { experienceName, bundleIdentifier });

try {
if (this.options.skipCredentialsCheck) {
log('Skipping credentials check...');
return;
}
log(
'Gathering and validating necessary credentials. To skip this step, pass in the --skip-credentials-check flag'
);
quinlanj marked this conversation as resolved.
Show resolved Hide resolved
await this.produceCredentials(context, experienceName, bundleIdentifier);
} catch (e) {
log(
Expand Down