Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ems][jest-expo-enzyme] Deprecate the library and remove it from EMS #19777

Merged
merged 2 commits into from
Oct 30, 2022
Merged

[ems][jest-expo-enzyme] Deprecate the library and remove it from EMS #19777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f09e3e
[ems][jest-expo-enzyme] Deprecate the library and remove it from EMS
brentvatne Oct 30, 2022
249add3
Update CHANGELOG [skip ci]
brentvatne Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/expo-module-scripts/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@

### 💡 Others

- Remove Enzyme plugin - it does not work with React 18. Not considered a breaking change because the Enzyme plugin has never worked with React 18 and so is already broken. ([#19777](https://github.com/expo/expo/pull/19777) by [@brentvatne](https://github.com/brentvatne))

## 3.0.1 — 2022-10-28

_This version does not introduce any user-facing changes._
Expand Down
16 changes: 0 additions & 16 deletions packages/expo-module-scripts/enzyme/jest-preset.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/expo-module-scripts/package.json
View file
Open in desktop
Expand Up @@ -37,7 +37,6 @@
"find-yarn-workspace-root": "^2.0.0",
"glob": "^7.1.7",
"jest-expo": "~47.0.0",
"jest-expo-enzyme": "^1.2.3",
"jest-watch-typeahead": "0.6.4",
"ts-jest": "~26.3.0",
"typescript": "^4.3.5"
Expand Down
12 changes: 11 additions & 1 deletion packages/html-elements/package.json
View file
Open in desktop
Expand Up @@ -33,7 +33,17 @@
"license": "MIT",
"homepage": "https://github.com/expo/expo/tree/main/packages/html-elements",
"jest": {
"preset": "expo-module-scripts/enzyme"
"projects": [
{
"preset": "jest-expo/ios"
},
{
"preset": "jest-expo/android"
},
{
"preset": "jest-expo/web"
}
]
},
"devDependencies": {
"expo-module-scripts": "^3.0.0"
Expand Down
78 changes: 48 additions & 30 deletions packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.android
View file
Open in desktop
Expand Up @@ -4,11 +4,14 @@ exports[`renders H1 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 64,
"fontWeight": "bold",
"marginVertical": 21.44,
}
Array [
Object {
"fontSize": 64,
"fontWeight": "bold",
"marginVertical": 21.44,
},
undefined,
]
}
/>
`;
Expand All @@ -17,11 +20,14 @@ exports[`renders H2 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 48,
"fontWeight": "bold",
"marginVertical": 26.56,
}
Array [
Object {
"fontSize": 48,
"fontWeight": "bold",
"marginVertical": 26.56,
},
undefined,
]
}
/>
`;
Expand All @@ -30,11 +36,14 @@ exports[`renders H3 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 37.44,
"fontWeight": "bold",
"marginVertical": 32,
}
Array [
Object {
"fontSize": 37.44,
"fontWeight": "bold",
"marginVertical": 32,
},
undefined,
]
}
/>
`;
Expand All @@ -43,11 +52,14 @@ exports[`renders H4 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 32,
"fontWeight": "bold",
"marginVertical": 42.56,
}
Array [
Object {
"fontSize": 32,
"fontWeight": "bold",
"marginVertical": 42.56,
},
undefined,
]
}
/>
`;
Expand All @@ -56,11 +68,14 @@ exports[`renders H5 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 26.56,
"fontWeight": "bold",
"marginVertical": 53.44,
}
Array [
Object {
"fontSize": 26.56,
"fontWeight": "bold",
"marginVertical": 53.44,
},
undefined,
]
}
/>
`;
Expand All @@ -69,11 +84,14 @@ exports[`renders H6 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 21.44,
"fontWeight": "bold",
"marginVertical": 74.56,
}
Array [
Object {
"fontSize": 21.44,
"fontWeight": "bold",
"marginVertical": 74.56,
},
undefined,
]
}
/>
`;
78 changes: 48 additions & 30 deletions packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.ios
View file
Open in desktop
Expand Up @@ -4,11 +4,14 @@ exports[`renders H1 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 64,
"fontWeight": "bold",
"marginVertical": 21.44,
}
Array [
Object {
"fontSize": 64,
"fontWeight": "bold",
"marginVertical": 21.44,
},
undefined,
]
}
/>
`;
Expand All @@ -17,11 +20,14 @@ exports[`renders H2 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 48,
"fontWeight": "bold",
"marginVertical": 26.56,
}
Array [
Object {
"fontSize": 48,
"fontWeight": "bold",
"marginVertical": 26.56,
},
undefined,
]
}
/>
`;
Expand All @@ -30,11 +36,14 @@ exports[`renders H3 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 37.44,
"fontWeight": "bold",
"marginVertical": 32,
}
Array [
Object {
"fontSize": 37.44,
"fontWeight": "bold",
"marginVertical": 32,
},
undefined,
]
}
/>
`;
Expand All @@ -43,11 +52,14 @@ exports[`renders H4 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 32,
"fontWeight": "bold",
"marginVertical": 42.56,
}
Array [
Object {
"fontSize": 32,
"fontWeight": "bold",
"marginVertical": 42.56,
},
undefined,
]
}
/>
`;
Expand All @@ -56,11 +68,14 @@ exports[`renders H5 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 26.56,
"fontWeight": "bold",
"marginVertical": 53.44,
}
Array [
Object {
"fontSize": 26.56,
"fontWeight": "bold",
"marginVertical": 53.44,
},
undefined,
]
}
/>
`;
Expand All @@ -69,11 +84,14 @@ exports[`renders H6 1`] = `
<Text
accessibilityRole="header"
style={
Object {
"fontSize": 21.44,
"fontWeight": "bold",
"marginVertical": 74.56,
}
Array [
Object {
"fontSize": 21.44,
"fontWeight": "bold",
"marginVertical": 74.56,
},
undefined,
]
}
/>
`;
17 changes: 10 additions & 7 deletions packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.android
View file
Open in desktop
Expand Up @@ -3,13 +3,16 @@
exports[`renders HR 1`] = `
<View
style={
Object {
"borderBottomColor": "#EEEEEE",
"borderBottomWidth": 0.5,
"borderTopColor": "#9A9A9A",
"borderTopWidth": 0.5,
"marginVertical": 8,
}
Array [
Object {
"borderBottomColor": "#EEEEEE",
"borderBottomWidth": 0.5,
"borderTopColor": "#9A9A9A",
"borderTopWidth": 0.5,
"marginVertical": 8,
},
undefined,
]
}
/>
`;
17 changes: 10 additions & 7 deletions packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.ios
View file
Open in desktop
Expand Up @@ -3,13 +3,16 @@
exports[`renders HR 1`] = `
<View
style={
Object {
"borderBottomColor": "#EEEEEE",
"borderBottomWidth": 0.5,
"borderTopColor": "#9A9A9A",
"borderTopWidth": 0.5,
"marginVertical": 8,
}
Array [
Object {
"borderBottomColor": "#EEEEEE",
"borderBottomWidth": 0.5,
"borderTopColor": "#9A9A9A",
"borderTopWidth": 0.5,
"marginVertical": 8,
},
undefined,
]
}
/>
`;