Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ems][jest-expo-enzyme] Deprecate the library and remove it from EMS #19777

Merged
merged 2 commits into from Oct 30, 2022

Conversation

brentvatne
Copy link
Member

Why

We include jest-expo-enzyme in expo-module-scripts, but this library is no longer supported as of React Native 0.68 / React 18+.

jest-expo-enzyme depends on @wojtekmaj/enzyme-adapter-react-17 which in turn has a peerDependency on react@17, so the result is that when creating a new project Expo module with npx create-expo-module we end up with react@17 and react@18 both installed in the project. As you can imagine, this does not work very well.

How

  • Deprecate in README
  • Remove from EMS
  • Update the one place we use it - in @expo/html-elements (which also had some broken snapshot tests, so I re-recorded them because the diff looked right)

Test Plan

CI

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 30, 2022
@brentvatne brentvatne merged commit 9e30274 into main Oct 30, 2022
@brentvatne brentvatne deleted the @brent/rip-enzyme branch October 30, 2022 03:05
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants