[router] enable testing on all platforms #27407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
commented
Mar 4, 2024
| @@ -1,3 +1,4 @@ | |||
| /** @jest-environment jsdom */ | |||
There was a problem hiding this comment.
This test uses import { render } from '@testing-library/react'; which assumes there is a DOM environment.
It looks like there is progress being made for better support for SSR and RSC
expo-bot
added
bot: passed checks
3 tasks
EvanBacon
approved these changes
Mar 12, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/router/enable-jest-platforms
branch
from
76aee02
to
71df55a
Compare
marklawlor
added a commit
that referenced
this pull request
Apr 26, 2024
# Why Revised version #26047 Blocked by #27407 # How Rules: * API routes cannot have platform extensions * Layouts and routes can have extensions only if a non-extension version exists For example, you have have `/page.web.tsx` only if `/page.tsx` also exists. This makes platform extensions an additive change and won't break concepts like universal deep linking and typed routes API routes do not support platform extensions as they are independent of a platform. # Implementation `getRoutes` allows multiple files to be assigned to the same route, but all files were given the same specificity. This PR adds logic to calculate the specificity of a file and to select the most specific file. Specificity highest-to-lowest `2`: Platform extension matches platform `1`: `.native` platform extension `0`: No platform extensions `-1`: Invalid route If no platform is provided to `getRoutes` the current behaviour is retained and files with platform extensions will be ignored. # `getRoutes` checklist These are the locations we use `getRoutes` and whether they should use platform extensions or not. **[renderStaticContent](https://github.com/expo/expo/blob/269625f5b70a95656212ad14ca7f3e82b45b9f61/packages/expo-router/src/static/renderStaticContent.tsx#L19)** - Used in `getManifest()` ❌ - Used in `getBuildTimeServerManifestAsync` ❌ - I'm not 100% sure on this one. Need to understand how to test this correctly **[routes-manifest]( https://github.com/expo/expo/blob/269625f5b70a95656212ad14ca7f3e82b45b9f61/packages/expo-router/src/routes-manifest.ts#L4)** - Used in `createRoutesManifest` ❌ **[router-store](https://github.com/expo/expo/blob/269625f5b70a95656212ad14ca7f3e82b45b9f61/packages/expo-router/src/global-state/router-store.tsx#L27)** - Used in `RouterStore` ✅ **[typed-routes](https://github.com/expo/expo/blob/269625f5b70a95656212ad14ca7f3e82b45b9f61/packages/expo-router/src/typed-routes/generate.ts#L5)** - Used in `getTypedRoutesDeclarationFile` ❌ There is also an `getExactRoutes` function, but this is only used for testing purposes. ** # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Evan Bacon <bacon@expo.io> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Update
jest.config.jsto enable tests on all platformsTest Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).