Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[router] enable testing on all platforms #27407

Merged
merged 5 commits into from Mar 13, 2024
Merged

[router] enable testing on all platforms #27407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0946654
[router]: enable testing on all platforms
marklawlor Mar 4, 2024
007bb81
changelog
marklawlor Mar 4, 2024
cf885e7
Update packages/expo-router/CHANGELOG.md
marklawlor Mar 4, 2024
3f56fc9
rename .test.native.ts[x] to .test.ios.ts[x]
marklawlor Mar 6, 2024
71df55a
cleanup test platform extensions
marklawlor Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/expo-router/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -26,6 +26,8 @@

### 💡 Others

- Enable Jest tests for all platforms ([#27407](https://github.com/expo/expo/pull/27407) by [@marklawlor](https://github.com/marklawlor))

## 3.4.8 - 2024-02-29

### 🎉 New features
Expand Down
8 changes: 4 additions & 4 deletions packages/expo-router/jest.config.js
View file
Open in desktop
@@ -1,8 +1,8 @@
const {
getWebPreset,
// getNodePreset,
getNodePreset,
getIOSPreset,
// getAndroidPreset,
getAndroidPreset,
} = require('jest-expo/config/getPlatformPreset');
const { withWatchPlugins } = require('jest-expo/config/withWatchPlugins');

Expand All @@ -19,8 +19,8 @@ module.exports = withWatchPlugins({
projects: [
// Create a new project for each platform.
getWebPreset(),
// getNodePreset(),
getNodePreset(),
getIOSPreset(),
// getAndroidPreset(),
getAndroidPreset(),
].map(withDefaults),
});
0 ...rc/__tests__/LocationProvider.test.web.ts → ...rc/__tests__/LocationProvider.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...po-router/src/__tests__/Route.test.web.ts → ...po-router/src/__tests__/Route.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 .../expo-router/src/__tests__/getId.test.tsx → ...o-router/src/__tests__/getId.test.ios.tsx
View file
Open in desktop
File renamed without changes.
0 ...ts__/getReactNavigationConfig.test.web.ts → ...ts__/getReactNavigationConfig.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...outer/src/__tests__/getRoutes.test.web.ts → ...outer/src/__tests__/getRoutes.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...c/__tests__/getServerManifest.test.web.ts → ...c/__tests__/getServerManifest.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...er/src/__tests__/globalState.test.web.tsx → ...er/src/__tests__/globalState.test.ios.tsx
View file
Open in desktop
File renamed without changes.
0 ...tests__/loadStaticParamsAsync.test.web.ts → ...tests__/loadStaticParamsAsync.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...router/src/__tests__/matchers.test.web.ts → ...router/src/__tests__/matchers.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...src/__tests__/type-generation.test.web.ts → ...rc/__tests__/type-generation.test.node.ts
View file
Open in desktop
File renamed without changes.
0 ...r/src/__tests__/useNavigation.test.web.ts → ...r/src/__tests__/useNavigation.test.ios.ts
View file
Open in desktop
File renamed without changes.
0 ...r/src/link/__tests__/Link.test.native.tsx → ...uter/src/link/__tests__/Link.test.ios.tsx
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/expo-router/src/link/__tests__/Link.test.web.tsx
View file
Open in desktop
@@ -1,3 +1,4 @@
/** @jest-environment jsdom */
Copy link
Contributor Author

@marklawlor marklawlor Mar 4, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test uses import { render } from '@testing-library/react'; which assumes there is a DOM environment.

It looks like there is progress being made for better support for SSR and RSC

import { render } from '@testing-library/react';
import React from 'react';
import { StyleSheet, Text, View } from 'react-native';
Expand Down