[router]: consolidate router types #27412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
force-pushed
the
marklawlor/router/consildate-types
branch
from
5e89646
to
cb56b95
Compare
Simek
reviewed
Mar 4, 2024
expo-bot
added
bot: passed checks
EvanBacon
reviewed
Mar 4, 2024
EvanBacon
approved these changes
Mar 12, 2024
marklawlor
force-pushed
the
marklawlor/router/consildate-types
branch
2 times, most recently
from
cbc8ae5
to
da8090f
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Evan Bacon <bacon@expo.io>
marklawlor
force-pushed
the
marklawlor/router/consildate-types
branch
from
c108a30
to
e4814a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Consolidate the types in Expo Router to use the same types used in type generation. This ensures there is only one source of truth for these types.
Also fixed some types that had drifted
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).