Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): filter ADB trace logs from the device list #27473

Merged
merged 2 commits into from Mar 28, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Mar 6, 2024

Why

Fixes #27421

How

Filter logs based on mentions of adb_trace.cpp:<line>, adb_client.cpp:<line>, or commandline.cpp:<line>.

Test Plan

See issue #27421

Checklist

@byCedric byCedric requested a review from EvanBacon as a code owner March 6, 2024 14:38
@byCedric byCedric force-pushed the @bycedric/cli/fix-issue-27421 branch from a7ae832 to a21d2d3 Compare March 6, 2024 14:38
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 6, 2024
@byCedric byCedric force-pushed the @bycedric/cli/fix-issue-27421 branch from 54e27e3 to da8bd14 Compare March 28, 2024 14:07
@byCedric byCedric merged commit a4df766 into main Mar 28, 2024
7 checks passed
@byCedric byCedric deleted the @bycedric/cli/fix-issue-27421 branch March 28, 2024 15:59
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find attached android devices when ADB_TRACE=adb is set
4 participants