upgrade react-native 0.73.5 #27502
Merged
upgrade react-native 0.73.5 #27502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-5
branch
from
7e1bdb6
to
29fc9c7
Compare
gabrieldonadel
requested review from
Simek,
amandeepmittal,
ide,
tsapeta,
brentvatne,
lukmccall and
douglowder
as code owners
tsapeta
approved these changes
Mar 7, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-5
branch
from
29fc9c7
to
92e201f
Compare
brentvatne
reviewed
Mar 7, 2024
| + "expo-status-bar": "~1.11.1", | ||
| + "react": "18.2.0", | ||
| + "react-native": "0.73.2" | ||
| + "react-native": "0.73.4" |
There was a problem hiding this comment.
Yeah, not sure why et generate-bare-diffs generated these changes
There was a problem hiding this comment.
So..., the et generate-bare-diffs command uses origin to generate the diffs.
I'll merge this PR and then open a follow-up updating the template diffs again
There was a problem hiding this comment.
Here you go #27520
brentvatne
reviewed
Mar 7, 2024
| @@ -2476,7 +2476,7 @@ index 69e7eb9619..150bb72764 100644 | |||
| + "expo": "~50.0.0-preview.4", | |||
| + "expo-status-bar": "~1.11.0", | |||
| + "react": "18.2.0", | |||
| + "react-native": "0.73.2" | |||
| + "react-native": "0.73.4" | |||
There was a problem hiding this comment.
ditto re: shouldn't this be 0.73.5?
There was a problem hiding this comment.
(similar things in other diffs)
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Mar 8, 2024
# Why Follow up of #27502 # How `et generate-bare-diffs` # Test Plan CI Should pass # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Mar 15, 2024
# Why Follow up #27502 for react-native 0.73 upgrade Template Bare Minimum Diffs will be addressed in a follow-up PR because of #27502 (comment) # How - update package versions - `react-native 0.73.5 -> 0.73.6` # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up #26774 for react-native 0.73 upgrade
How
react-native 0.73.4 -> 0.73.5Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).