[router]: remove jest.fakeTimers from expo-router/testing-library #27512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Mar 12, 2024
3 tasks
marklawlor
added a commit
that referenced
this pull request
Mar 14, 2024
# Why #27512 is causing extra console logging due to the `requestAnimationFrame` used by Expo Router to hide the splash screen. Previously this logic was never invoked as we were using fake timers, but now we need to cancel the timeout so it doesn't run after the tests have ended. # How Added a `cleanup()` to `expo-router/testing-library` that removes the `requestAnimationFrame` if it has not run yet. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix: #27484
jest.fakeTimers()are only used by the<Drawer />/<Stack />for controlling the animation. This shouldn't be a global setting in people's tests and it should only be enabled in a case by case basis when required.How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).