Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[router]: remove jest.fakeTimers from expo-router/testing-library #27512

Merged
merged 3 commits into from Mar 13, 2024
Merged

[router]: remove jest.fakeTimers from expo-router/testing-library #27512

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5538fe
[router]: remove jest.fakeTimers from expo-router/testing-library
marklawlor Mar 8, 2024
632c27a
Update packages/expo-router/CHANGELOG.md
marklawlor Mar 8, 2024
0b68905
Merge branch 'main' into marklawlor/router/remove-fake-timers
marklawlor Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/expo-router/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -23,6 +23,7 @@
- Fix `push` navigation not pushing the same route multiple times ([#27307](https://github.com/expo/expo/pull/27307) by [@marklawlor](https://github.com/marklawlor))
- Fix router.navigate will only push when path parameters change ([#27285](https://github.com/expo/expo/pull/27285) by [@marklawlor](https://github.com/marklawlor))
- Fix incorrect route generation of array shared groups with brackets ([#27459](https://github.com/expo/expo/pull/27459) by [@marklawlor](https://github.com/marklawlor))
- Remove `jest.fakeTimers()` from `expo-router/testing-library` ([#27512](https://github.com/expo/expo/pull/27512) by [@marklawlor](https://github.com/marklawlor))

### 💡 Others

Expand Down
2 changes: 1 addition & 1 deletion packages/expo-router/build/testing-library/index.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/expo-router/build/testing-library/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-router/build/testing-library/index.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions packages/expo-router/src/testing-library/index.tsx
View file
Open in desktop
Expand Up @@ -32,8 +32,6 @@ export function renderRouter(
context: MockContextConfig = './app',
{ initialUrl = '/', ...options }: RenderRouterOptions = {}
): Result {
jest.useFakeTimers();

const mockContext = getMockContext(context);

// Reset the initial URL
Expand Down