Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel): write new inline Platform module plugin #27533

Merged
merged 11 commits into from Mar 13, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • The upstream module has a lot of concessions for legacy features that don't appear to be used anymore, like importing from a module named require("Platform") (Haste).
  • We also want to combine the dev inlining with our other inlines via feat(babel): minify typeof window #27530
  • I've also added correct handling for web, where we'll now remove the native fallback option.
  • Finally, I added support for Platform["OS"].

Test Plan

  • Added a bunch of tests for the expected functionality.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 8, 2024
@EvanBacon EvanBacon marked this pull request as ready for review March 13, 2024 18:36
EvanBacon and others added 2 commits March 13, 2024 13:40
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 13, 2024
@EvanBacon EvanBacon merged commit e936f33 into main Mar 13, 2024
22 of 23 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babel/inline-platform-fork branch March 13, 2024 20:20
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants