New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] "Existing React Native apps" and "Existing native apps" docs groups #27608
Conversation
brentvatne
commented
Mar 12, 2024
•
edited
edited
- Rename "Bare React Native" to "Existing React Native apps"
- Stopped telling people how to initialize bare apps there.
- We should do more work to integrate instructions for how to configure libraries for bare apps within the docs sections for the respective tools, eg: dev client and updates shouldn't delegate to a specific section for this. Instead, the docs within this "Existing React Native apps" section should explain why you would want to use the tools in that context and tell people anything they might need to know beyond what is explained in the normal bare setup instructions (that we then link to).
- Cleaned up a bunch of the docs within the "Existing React Native apps" section.
- Moved the guide about working around running your app in Expo Go even if it has custom native code. We don't want to encourage this, folks should use dev builds.
- Add "Existing native apps" section. This includes our first pass at explaining how to use Expo modules in a "brownfield" app context. I expect we will extend this section more, for now it's more of a stake in the ground with appropriate warnings.
53c2e47
to
512e2fe
Compare
📘 Your docs preview website is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comments, I think it would be good to order Kotlin before Swift since we typically order Android before iOS. That way the programming languages line up (but also K does come before S, but that's not the motivation).
/> | ||
</Step> | ||
|
||
## Configure your Android app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: move this whole section above "Configure your iOS app" to match the (Android, iOS) ordering we use elsewhere mostly.
</Step> | ||
|
||
<Step label="3"> | ||
If you have your own class extending `Application`, you can add the following to it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain why you'd want to add it. The phrasing ("you can") says that you have the choice but doesn't explain why you'd want to make that choice or how to decide.
Co-authored-by: James Ide <ide@users.noreply.github.com>