feat(jest-expo): support passing caller to babel-jest #27637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
marklawlor
pushed a commit
that referenced
this pull request
Mar 18, 2024
# Why If the project babel config is babel-preset-expo then it should have access to the target platform that the bundler is transforming for. In this case, the bundler is Jest, so we need to supply the platform caller option to babel jest to ensure platform-specific transforms can be applied in a predictable way. # Test Plan - I added a test for the new behavior to ensure `process.env.EXPO_OS` is available in tests that use `babel-preset-expo`. Hopefully all other tests continue to pass as expected. - It's unclear if we should also pass `isDev` to the caller as well. It seems like we currently support users toggling this at runtime in tests. - Ran `et cp -a --no-build --no-lint --no-uniformity-check` to ensure all tests keep working. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the project babel config is babel-preset-expo then it should have access to the target platform that the bundler is transforming for. In this case, the bundler is Jest, so we need to supply the platform caller option to babel jest to ensure platform-specific transforms can be applied in a predictable way.
Test Plan
process.env.EXPO_OSis available in tests that usebabel-preset-expo. Hopefully all other tests continue to pass as expected.isDevto the caller as well. It seems like we currently support users toggling this at runtime in tests.et cp -a --no-build --no-lint --no-uniformity-checkto ensure all tests keep working.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).