Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-expo): support passing caller to babel-jest #27637

Merged
merged 3 commits into from Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/jest-expo/CHANGELOG.md
Expand Up @@ -6,6 +6,8 @@

### 🎉 New features

- Add support for internal `process.env.EXPO_OS` environment variable and passing `platform` to `babel-jest` caller. ([#27637](https://github.com/expo/expo/pull/27637) by [@EvanBacon](https://github.com/EvanBacon))

### 🐛 Bug fixes

### 💡 Others
Expand Down
42 changes: 37 additions & 5 deletions packages/jest-expo/config/getPlatformPreset.js
Expand Up @@ -4,7 +4,16 @@ const { getBareExtensions } = require('@expo/config/paths');
const { withWatchPlugins } = require('./withWatchPlugins');
const expoPreset = require('../jest-preset');

function getPlatformPreset(displayOptions, extensions) {
function getUpstreamBabelJest(transform) {
const upstreamBabelJest = Object.keys(transform).find((key) =>
Array.isArray(transform[key])
? transform[key][0] === 'babel-jest'
: transform[key] === 'babel-jest'
);
return upstreamBabelJest;
}

function getPlatformPreset(displayOptions, extensions, platform, isServer) {
const moduleFileExtensions = getBareExtensions(extensions, {
isTS: true,
isReact: true,
Expand All @@ -20,7 +29,26 @@ function getPlatformPreset(displayOptions, extensions) {
];
});

const upstreamBabelJest = getUpstreamBabelJest(expoPreset.transform) ?? '\\.[jt]sx?$';

return withWatchPlugins({
transform: {
...expoPreset.transform,
[upstreamBabelJest]: [
'babel-jest',
{
caller: {
name: 'metro',
bundler: 'metro',
// Add support for the `platform` babel transforms and inlines such as
// Platform.OS and `process.env.EXPO_OS`.
platform,
// Add support for removing server related code from the bundle.
isServer,
},
},
],
},
displayName: displayOptions,
testMatch,
moduleFileExtensions,
Expand Down Expand Up @@ -52,27 +80,31 @@ module.exports = {
getWebPreset() {
return {
...getBaseWebPreset(),
...getPlatformPreset({ name: 'Web', color: 'magenta' }, ['web']),
...getPlatformPreset({ name: 'Web', color: 'magenta' }, ['web'], 'web'),
testEnvironment: 'jsdom',
};
},
getNodePreset() {
return {
...getBaseWebPreset(),
...getPlatformPreset({ name: 'Node', color: 'cyan' }, ['node', 'web']),
...getPlatformPreset({ name: 'Node', color: 'cyan' }, ['node', 'web'], 'web', true),
testEnvironment: 'node',
};
},
getIOSPreset() {
return {
...expoPreset,
...getPlatformPreset({ name: 'iOS', color: 'white' }, ['ios', 'native']),
...getPlatformPreset({ name: 'iOS', color: 'white' }, ['ios', 'native'], 'ios'),
};
},
getAndroidPreset() {
return {
...expoPreset,
...getPlatformPreset({ name: 'Android', color: 'blueBright' }, ['android', 'native']),
...getPlatformPreset(
{ name: 'Android', color: 'blueBright' },
['android', 'native'],
'android'
),
};
},
};
16 changes: 11 additions & 5 deletions packages/jest-expo/jest-preset.js
Expand Up @@ -14,13 +14,19 @@ jestPreset.moduleNameMapper = {
'^react-native-vector-icons/(.*)': '@expo/vector-icons/$1',
};

// transform
if (!jestPreset.transform) {
jestPreset.transform = {
'\\.[jt]sx?$': 'babel-jest',
};
const upstreamBabelJest = Object.keys(jestPreset.transform).find(
(key) => jestPreset.transform[key] === 'babel-jest'
);
if (upstreamBabelJest) {
delete jestPreset.transform[upstreamBabelJest];
}

// transform
jestPreset.transform['\\.[jt]sx?$'] = [
'babel-jest',
{ caller: { name: 'metro', bundler: 'metro', platform: 'ios' } },
];

const defaultAssetNamePattern = '^.+\\.(bmp|gif|jpg|jpeg|mp4|png|psd|svg|webp)$';
if (!jestPreset.transform[defaultAssetNamePattern]) {
console.warn(`Expected react-native/jest-preset to define transform[${defaultAssetNamePattern}]`);
Expand Down
7 changes: 7 additions & 0 deletions packages/jest-expo/tests/__tests__/jest-test.js
Expand Up @@ -11,4 +11,11 @@ describe(`jest-expo/universal`, () => {
expect(OS).toContain(Platform.OS);
expect(OS).toMatchSnapshot();
});

it(`injects process.env.EXPO_OS via babel-preset-expo automatically`, () => {
const { OS } = require('../default-extension');
const { Platform } = require('expo-modules-core');
expect(Platform.OS).toEqual(process.env.EXPO_OS);
expect(OS).toContain(process.env.EXPO_OS);
});
});