[router]: change Href to not be generic / use expo-router package for tests #27690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
commented
Mar 15, 2024
| @@ -1,46 +1,38 @@ | |||
| import { getTypedRoutesDeclarationFile } from 'expo-router/build/typed-routes/generate'; | |||
There was a problem hiding this comment.
@EvanBacon I think this will break with your incoming changes. Please let me know what I should change it to
marklawlor
commented
Mar 15, 2024
| dynamicRoutes: string[]; | ||
| dynamicRouteTemplates: string[]; | ||
| }; | ||
| function getMockContext(context: string[]) { |
There was a problem hiding this comment.
We don't need a real context here. The helpers inside Expo Router are not publicly exposed, and trying to access them is a commonjs/esm hassle.
expo-bot
added
bot: passed checks
marklawlor
force-pushed
the
marklawlor/typed-routes/groups
branch
from
ba2f44c
to
ff64a41
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
marklawlor
force-pushed
the
marklawlor/typed-routes/groups
branch
from
ff64a41
to
3fb5cd3
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/typed-routes/groups
branch
from
3fb5cd3
to
f77cd3b
Compare
EvanBacon
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There PR is multiple fixes for typed routes
Expo Router now provides the utility functions to generate the
.d.tsfile used for typed routes. This PR changes the@expo/clitests to generate the fixture file using these functions.Href<T>toHrefI've personally had some issues with using custom components wrapped in
fowardRefthat useHreffor a prop.forwardRefdoesn't work well with generic components, so I've refactored the types soHrefis no longer generic.Not only does this fix this issue, it improves the editor autocomplete when inferring the
Hrefvalue./(groups)/in typed routes.Technically they were always allowed, but partial routes are allowed. For example you can do
/(group1)/(group2)/pageor simply/(group1)/pageor even just/page.Hrefcan be assigned to as expected.With the changes to
HrefI've added new set to tests to ensure users can assign values toHrefas expected.How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).